Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

685 NE instead of NA #690

Closed
wants to merge 2 commits into from
Closed

685 NE instead of NA #690

wants to merge 2 commits into from

Conversation

BFalquet
Copy link
Contributor

@BFalquet BFalquet commented Oct 31, 2023 •
edited
Loading

close #685

use option to define the string replacing NA. On load the default replacement is NE.

thank you for the review

@clarkliming
Copy link
Contributor

will this be addressed in tern side? (otherwise every na_str should be updated and there are just too many positions. including plots?)

@BFalquet
Copy link
Contributor Author

BFalquet commented Dec 8, 2023

superseeded by #710

@BFalquet BFalquet closed this Dec 8, 2023
@BFalquet BFalquet deleted the 685-ne-instead-of-na@main branch February 1, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarkliming clarkliming Awaiting requested review from clarkliming clarkliming will be requested when the pull request is marked ready for review clarkliming is a code owner

Assignees
No one assigned
Labels
chevron on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NE instead of NA
2 participants
@BFalquet @clarkliming