try with time zone detection

DESCRIPTION

@@ -36,7 +36,6 @@ Imports:
     glue (>= 1.0.0),
     grid,
     lifecycle (>= 0.2.0),
-    lubridate,
     magrittr (>= 1.5),
     methods,
     nestcolor (>= 0.1.1),

NAMESPACE

@@ -254,7 +254,6 @@ importFrom(glue,glue)
 importFrom(grid,stringWidth)
 importFrom(grid,unit)
 importFrom(lifecycle,deprecated)
-importFrom(lubridate,date)
 importFrom(magrittr,"%>%")
 importFrom(methods,is)
 importFrom(methods,setValidity)

R/package.R

@@ -12,7 +12,6 @@
 #' @importFrom grid stringWidth unit
 #' @importFrom glue glue
 #' @importFrom lifecycle deprecated
-#' @importFrom lubridate date
 #' @importFrom magrittr %>%
 #' @importFrom methods is setValidity
 #' @importFrom nestcolor color_palette

R/utils.R

@@ -438,20 +438,29 @@ listing_format_chevron <- function() {
 #'
 #' @return a `function` converting a date into `string`.
 #'
-#' @export
+#' @note The date is extracted at the location of the measure, not at the location of the system.
 #'
+#' @export
+#' @examples
+#' format_date("%d%b%Y")("2021-01-01")
+#' format_date("%d%b%Y")(as.Date("2021-01-01"))
+#' format_date("%d%b%Y")(as.POSIXct("2021-01-01 00:00:01", tz = "NZ"))
+#' format_date("%d%b%Y")(as.POSIXct("2021-01-01 00:00:01", tz = "US/Pacific"))
 format_date <- function(date_format = "%d%b%Y") {
   function(x, ...) {
     toupper(
       format(
-        # Extract the date at the location of the measure, not at the location of the System.
-        lubridate::date(x),
+        # Extract the date at the location of the measure, not at the location of the system.
+        as.Date(x, tz = attr(x, "tzone")),
         date_format
       )
     )
   }
 }
 
+
+
+
 # listing_id ----
 
 #' Concatenate Site and Subject ID

tests/testthat/test-utils.R

@@ -315,3 +315,31 @@ test_that("gg_list is deprecated", {
     }
   )
 })
+
+test_that("format_date works as expected for POSIXct", {
+  d <- as.POSIXct("2019-01-01 00:00:01", tz = "NZ")
+
+  withr::with_timezone("Europe/Paris", {
+    foo <- format_date()
+    expect_identical(foo(d), "01JAN2019")
+  })
+
+  withr::with_timezone("NZ", {
+    foo <- format_date()
+    expect_identical(foo(d), "01JAN2019")
+  })
+})
+
+test_that("format_date works as expected for Date", {
+  d <- as.Date("2019-01-01 00:00:01", tz = "NZ")
+
+  withr::with_timezone("Europe/Paris", {
+    foo <- format_date()
+    expect_identical(foo(d), "01JAN2019")
+  })
+
+  withr::with_timezone("NZ", {
+    foo <- format_date()
+    expect_identical(foo(d), "01JAN2019")
+  })
+})