Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ard_svychisq() function #83

Merged
merged 17 commits into from
Mar 15, 2024
Merged

add ard_svychisq() function #83

merged 17 commits into from
Mar 15, 2024

Conversation

ayogasekaram
Copy link
Contributor

@ayogasekaram ayogasekaram commented Mar 12, 2024

What changes are proposed in this pull request?
add ard_svychisq function #72 @ayogasekaram
Provide more detail here as needed.

closes #72


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.56%. Comparing base (dd87d7c) to head (8b3bd99).
Report is 1 commits behind head on main.

❗ Current head 8b3bd99 differs from pull request most recent head 9ae22cb. Consider uploading reports for the commit 9ae22cb to get more accurate results

Files Patch % Lines
R/ard_svychisq.R 96.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   98.62%   98.56%   -0.07%     
==========================================
  Files          17       18       +1     
  Lines         874      904      +30     
==========================================
+ Hits          862      891      +29     
- Misses         12       13       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Mar 12, 2024

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  ------------------------------------
R/ard_car_anova.R              41       2  95.12%   57, 60
R/ard_chisqtest.R              31       0  100.00%
R/ard_cohens_d.R               87       2  97.70%   64, 107
R/ard_fishertest.R             33       0  100.00%
R/ard_hedges_g.R               75       2  97.33%   63, 106
R/ard_kruskaltest.R            27       0  100.00%
R/ard_mcnemartest.R            41       0  100.00%
R/ard_moodtest.R               47       1  97.87%   44
R/ard_proportion_ci.R          40       5  87.50%   63-67
R/ard_proptest.R               71       0  100.00%
R/ard_regression_basic.R       14       1  92.86%   44
R/ard_regression.R             49       0  100.00%
R/ard_smd.R                    40       0  100.00%
R/ard_svychisq.R               36       1  97.22%   42
R/ard_ttest.R                  78       0  100.00%
R/ard_vif.R                    58       2  96.55%   46, 80
R/ard_wilcoxtest.R             97       2  97.94%   61, 103
R/proportion_ci.R             188      28  85.11%   275, 278, 287-292, 300, 315, 415-438
TOTAL                        1053      46  95.63%

Diff against main

Filename            Stmts    Miss  Cover
----------------  -------  ------  -------
R/ard_svychisq.R      +36      +1  +97.22%
TOTAL                 +36      +1  +0.06%

Results for commit: 9ae22cb

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Mar 12, 2024

Unit Tests Summary

 1 files  30 suites   4s ⏱️
29 tests 21 ✅  8 💤 0 ❌
74 runs  54 ✅ 20 💤 0 ❌

Results for commit 9ae22cb.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 12, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ard_svychisq 👶 $+0.12$ $+3$ $+1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_svychisq 👶 $+0.12$ ard_svychisq_works

Results for commit 8b3bd99

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking great! Just a few initial comments

R/ard_svychisq.R Outdated Show resolved Hide resolved
R/ard_svychisq.R Outdated Show resolved Hide resolved
R/ard_svychisq.R Outdated Show resolved Hide resolved
R/ard_svychisq.R Outdated Show resolved Hide resolved
R/ard_svychisq.R Outdated Show resolved Hide resolved
R/ard_svychisq.R Outdated Show resolved Hide resolved
@ddsjoberg ddsjoberg changed the title add ard_svychisq function add ard_svychisq() function Mar 12, 2024
@ddsjoberg ddsjoberg self-requested a review March 15, 2024 03:34
Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Thank you!

@ddsjoberg ddsjoberg merged commit a76c5c0 into main Mar 15, 2024
28 checks passed
@ddsjoberg ddsjoberg deleted the 72_svy_chisq@main branch March 15, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARD for survey::svychisq()
3 participants