Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial setup #8

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Initial setup #8

merged 6 commits into from
Jan 23, 2024

Conversation

ddsjoberg
Copy link
Collaborator

@ddsjoberg ddsjoberg commented Jan 23, 2024

Questions:

  1. Can we discuss ./tests/testhat/setup.R? I am not sure I understand what it's doing.
    • I can delete this file.
  2. What is the reporter here? test_check(pkg_name, reporter = ParallelProgressReporter$new())
    • Is this similar to the parallel processing of unit tests available in testthat edition 3 (which is opt-in)?
    • Can I add Config/testthat/parallel: true to the DESCRIPTION without breaking things?
    • ADDED the config to DESCRIPTION, and no longer need the reporter.
  3. .pre-commit-config.yaml The defaults here are styling and re-documenting, right? But we have workflows for those as well. Do we need both? What is the role of all the dependencies listed in the file?
    • I can leave this and not install the pre-commit hooks. Or i can delete this
  4. .gitlab-ci.yml, do I need this one since this is a GH repo? KEEP THIS BECAUSE WE WILL NEED IT FOR VALIDATION.
  5. Where are staged dependencies used? I see them in the R CMD Checks yaml. Any other spaces? I don't think I need that infrastructure right now: if I delete the file now, will it break existing workflows?
    • I CAN DELETE OR NOT DELETE
  6. build-check-install.yaml
    • Can we discuss the details of junit-xml reports, so I can understand what they are doing?
    • What versions of R are checked? A project like cards need to be checked on the last 4 versions of R.
      • This checks one version of R only for now. This may change in the future. For now, I'll probably just add the Posit checks for older versions.
    • The reports that are uploaded to the pkgdown site, are the just static html files? If I prefer not to add a dropdown menu that persists all every page of the website, can I link to them another way?
      • I can delete these menus from the _pkgdown.yaml, and then add a link via a fa-icon
    • Is this built similarly to the admiral workflows based off images that update every so often? If so, how frequently do they update? What if I need to use a new feature from a package?
  7. I ❤️ branch-cleanup. Did I specify this option correctly?

image

  1. Does either the lintr or styler actually change my scripts or just report when they are not properly linted/styled? If so, can that be changed to just report?

Copy link
Contributor

Unit Tests Summary

1 tests   1 ✅  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 16a4c7d.

@ddsjoberg ddsjoberg merged commit e3b365f into main Jan 23, 2024
24 of 25 checks passed
@ddsjoberg ddsjoberg deleted the initial-setups branch January 23, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant