Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ard_svyttest() #75

Merged
merged 9 commits into from
Mar 15, 2024
Merged

adding ard_svyttest() #75

merged 9 commits into from
Mar 15, 2024

Conversation

ddsjoberg
Copy link
Collaborator

@ddsjoberg ddsjoberg commented Mar 9, 2024

What changes are proposed in this pull request?

  • Adding ard_svyttest()

Reference GitHub issue associated with pull request. e.g., 'closes #'
closes #70


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 95.41%. Comparing base (e880f74) to head (876ebf9).
Report is 1 commits behind head on main.

❗ Current head 876ebf9 differs from pull request most recent head 9339fb6. Consider uploading reports for the commit 9339fb6 to get more accurate results

Files Patch % Lines
R/ard_svyttest.R 0.00% 35 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   99.40%   95.41%   -3.99%     
==========================================
  Files          17       18       +1     
  Lines         838      873      +35     
==========================================
  Hits          833      833              
- Misses          5       40      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddsjoberg ddsjoberg marked this pull request as ready for review March 9, 2024 02:17
Copy link
Contributor

github-actions bot commented Mar 9, 2024

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  ------------------------------------
R/ard_car_anova.R              41       2  95.12%   57, 60
R/ard_chisqtest.R              31       0  100.00%
R/ard_cohens_d.R               87       2  97.70%   64, 107
R/ard_fishertest.R             33       0  100.00%
R/ard_hedges_g.R               75       2  97.33%   63, 106
R/ard_kruskaltest.R            27       0  100.00%
R/ard_mcnemartest.R            41       0  100.00%
R/ard_moodtest.R               47       1  97.87%   44
R/ard_proportion_ci.R          40       5  87.50%   63-67
R/ard_proptest.R               71       0  100.00%
R/ard_regression_basic.R       14       1  92.86%   44
R/ard_regression.R             49       0  100.00%
R/ard_smd.R                    40       0  100.00%
R/ard_svychisq.R               36       1  97.22%   42
R/ard_svyttest.R               49       0  100.00%
R/ard_ttest.R                  92       2  97.83%   61, 103
R/ard_vif.R                    58       2  96.55%   46, 80
R/ard_wilcoxtest.R             97       2  97.94%   61, 103
R/proportion_ci.R             188      28  85.11%   275, 278, 287-292, 300, 315, 415-438
TOTAL                        1116      48  95.70%

Diff against main

Filename            Stmts    Miss  Cover
----------------  -------  ------  --------
R/ard_svyttest.R      +49       0  +100.00%
TOTAL                 +49       0  +0.20%

Results for commit: 62da84f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Mar 9, 2024

Unit Tests Summary

 1 files  32 suites   5s ⏱️
31 tests 23 ✅  8 💤 0 ❌
80 runs  60 ✅ 20 💤 0 ❌

Results for commit 62da84f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 9, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ard_svyttest 👶 $+0.00$ $+2$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_svyttest 👶 $+0.00$ ard_svyttest_messaging
ard_svyttest 👶 $+0.13$ ard_svyttest_works

Results for commit ef92077

♻️ This comment has been updated with latest results.

@ddsjoberg ddsjoberg changed the title adding ard_svyttest() adding ard_svyttest() Mar 11, 2024
@ayogasekaram ayogasekaram self-requested a review March 13, 2024 17:37
R/ard_svyttest.R Outdated Show resolved Hide resolved
R/ard_svyttest.R Outdated Show resolved Hide resolved
@ddsjoberg ddsjoberg requested a review from ayogasekaram March 15, 2024 03:18
@ddsjoberg
Copy link
Collaborator Author

Thank you @ayogasekaram ! I responded to your comments and we're ready for a followup review 👍🏼

Copy link
Contributor

@ayogasekaram ayogasekaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful! Thank you @ddsjoberg

@ddsjoberg ddsjoberg merged commit 8d12ac8 into main Mar 15, 2024
27 of 28 checks passed
@ddsjoberg ddsjoberg deleted the svyttest branch March 15, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARD for survey::svyttest()
3 participants