Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ard_proptest() #64

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Adding ard_proptest() #64

merged 6 commits into from
Mar 4, 2024

Conversation

ddsjoberg
Copy link
Collaborator

@ddsjoberg ddsjoberg commented Mar 2, 2024

What changes are proposed in this pull request?

  • Added ard_proptest() for 2-sample tests of proportions.

closes #4


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.72%. Comparing base (ade0c33) to head (e396870).
Report is 1 commits behind head on main.

❗ Current head e396870 differs from pull request most recent head cbb14cf. Consider uploading reports for the commit cbb14cf to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   99.69%   99.72%   +0.02%     
==========================================
  Files          13       14       +1     
  Lines         663      722      +59     
==========================================
+ Hits          661      720      +59     
  Misses          2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Mar 2, 2024

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  ------------------------------------
R/ard_chisqtest.R              31       0  100.00%
R/ard_cohens_d.R               74       0  100.00%
R/ard_fishertest.R             33       0  100.00%
R/ard_hedges_g.R               61       0  100.00%
R/ard_kruskaltest.R            27       0  100.00%
R/ard_mcnemartest.R            41       0  100.00%
R/ard_moodtest.R               40       0  100.00%
R/ard_proportion_ci.R          40       5  87.50%   63-67
R/ard_proptest.R               71       0  100.00%
R/ard_regression_basic.R       14       1  92.86%   44
R/ard_regression.R             49       0  100.00%
R/ard_ttest.R                  78       0  100.00%
R/ard_wilcoxtest.R             83       0  100.00%
R/proportion_ci.R             188      28  85.11%   247, 250, 259-264, 272, 287, 387-410
TOTAL                         830      34  95.90%

Diff against main

Filename            Stmts    Miss  Cover
----------------  -------  ------  --------
R/ard_proptest.R      +71       0  +100.00%
TOTAL                 +71       0  +0.38%

Results for commit: cbb14cf

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Mar 2, 2024

Unit Tests Summary

 1 files  22 suites   4s ⏱️
22 tests 18 ✅  4 💤 0 ❌
57 runs  43 ✅ 14 💤 0 ❌

Results for commit cbb14cf.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 2, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ard_proptest 👶 $+0.01$ $+8$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_proptest 👶 $+0.01$ ard_proptest_error_messaging
ard_proptest 👶 $+0.28$ ard_proptest_works

Results for commit e396870

♻️ This comment has been updated with latest results.

@edelarua edelarua self-assigned this Mar 4, 2024
Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one typo to fix - otherwise all looks good!

R/ard_proptest.R Outdated Show resolved Hide resolved
ddsjoberg and others added 2 commits March 4, 2024 15:11
Co-authored-by: Emily de la Rua <[email protected]>
Signed-off-by: Daniel Sjoberg <[email protected]>
@ddsjoberg ddsjoberg merged commit 7e73da8 into main Mar 4, 2024
28 checks passed
@ddsjoberg ddsjoberg deleted the ard_proptest branch March 4, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ARD for differences
3 participants