Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #52 for moods test #52

Merged
merged 12 commits into from
Feb 21, 2024
Merged

Closes #52 for moods test #52

merged 12 commits into from
Feb 21, 2024

Conversation

zdz2101
Copy link
Contributor

@zdz2101 zdz2101 commented Feb 15, 2024

What changes are proposed in this pull request?

  • Style this entry in a way that can be copied directly into NEWS.md. (#, @)

Provide more detail here as needed.

Reference GitHub issue associated with pull request. e.g., 'closes #'


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

@zdz2101 zdz2101 linked an issue Feb 15, 2024 that may be closed by this pull request
@zdz2101 zdz2101 changed the title initial commit/draft Closes #52 for moods test Feb 19, 2024
@zdz2101 zdz2101 marked this pull request as ready for review February 19, 2024 17:22
Copy link
Contributor

github-actions bot commented Feb 19, 2024

Unit Tests Summary

 1 files  15 suites   2s ⏱️
15 tests 11 ✅ 4 💤 0 ❌
33 runs  24 ✅ 9 💤 0 ❌

Results for commit f7c9051.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 19, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ard_moodtest 👶 $+0.15$ $+3$ $+1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_moodtest 👶 $+0.15$ ard_moodtest_works

Results for commit 84bc4f3

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 19, 2024

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ------------------------------------
R/ard_chisqtest.R           31       0  100.00%
R/ard_fishertest.R          33       0  100.00%
R/ard_kruskaltest.R         27       0  100.00%
R/ard_mcnemartest.R         41       0  100.00%
R/ard_moodtest.R            40       0  100.00%
R/ard_proportion_ci.R       40       5  87.50%   63-67
R/ard_regression.R          49       0  100.00%
R/ard_ttest.R               78       0  100.00%
R/ard_wilcoxtest.R          83       0  100.00%
R/proportion_ci.R          182      28  84.62%   241, 244, 253-258, 266, 281, 381-404
TOTAL                      604      33  94.54%

Diff against main

Filename            Stmts    Miss  Cover
----------------  -------  ------  --------
R/ard_moodtest.R      +40       0  +100.00%
TOTAL                 +40       0  +0.39%

Results for commit: f7c9051

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (39ccf3f) 99.79% compared to head (557f065) 99.81%.
Report is 2 commits behind head on main.

❗ Current head 557f065 differs from pull request most recent head 4e31446. Consider uploading reports for the commit 4e31446 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   99.79%   99.81%   +0.01%     
==========================================
  Files           9       10       +1     
  Lines         494      528      +34     
==========================================
+ Hits          493      527      +34     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddsjoberg ddsjoberg self-requested a review February 21, 2024 18:10
Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @zdz2101 !!

In future PRs, can you fill out the PR header info and the checklist?
image

@ddsjoberg ddsjoberg merged commit 28eaf30 into main Feb 21, 2024
28 checks passed
@ddsjoberg ddsjoberg deleted the 37-ard-for-moods-test branch February 21, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARD for Mood's Test
4 participants