-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #38 adding Kruskal-Wallis test #45
Conversation
Code Coverage Summary
Diff against main
Results for commit: 978d067 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 13 suites 2s ⏱️ Results for commit 978d067. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit 5775ceb ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zdz2101 wow, quick turn-around! 🌟 🌟
I took a quick look with a few initial comments.
tests/testthat/test-ard_kwtest.R
Outdated
) | ||
}) | ||
|
||
test_that("shuffle_ard fills missing group levels if the group is meaningful", { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather than testing shuffle, can we stick with as.data.frame()
on the ARD table?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few final comments, thank you @zdz2101 !
…tsengineering/cardx into 38-ard-for-kruskal-wallis
Signed-off-by: Daniel Sjoberg <[email protected]>
Signed-off-by: Zelos Zhu <[email protected]>
hey hey @zdz2101 ! I think this PR is good to go after the updates to the snapshot tests. 1. Let's test with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @zdz2101 !!
What changes are proposed in this pull request?
Reference GitHub issue associated with pull request. e.g., 'closes #38 '
Reviewer Checklist (if item does not apply, mark is as complete)
devtools::install_dev_deps()
usethis::pr_merge_main()
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.devtools::test_coverage()
usethis::use_spell_check()
runs with no spelling errors in documentationWhen the branch is ready to be merged:
NEWS.md
with the changes from this pull request under the heading "# cards (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).usethis::use_version(which = "dev")
usethis::use_spell_check()
again