Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #38 adding Kruskal-Wallis test #45

Merged
merged 27 commits into from
Feb 17, 2024
Merged

Conversation

zdz2101
Copy link
Contributor

@zdz2101 zdz2101 commented Feb 7, 2024

What changes are proposed in this pull request?

Reference GitHub issue associated with pull request. e.g., 'closes #38 '


Reviewer Checklist (if item does not apply, mark is as complete)

  • Ensure all package dependencies are installed: devtools::install_dev_deps()
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()
  • usethis::use_spell_check() runs with no spelling errors in documentation

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Increment the version number using usethis::use_version(which = "dev")
  • Run usethis::use_spell_check() again
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

@zdz2101 zdz2101 linked an issue Feb 7, 2024 that may be closed by this pull request
@zdz2101 zdz2101 marked this pull request as ready for review February 7, 2024 18:36
Copy link
Contributor

github-actions bot commented Feb 7, 2024

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ------------------------------------
R/ard_chisqtest.R           31       0  100.00%
R/ard_fishertest.R          33       0  100.00%
R/ard_kruskaltest.R         27       0  100.00%
R/ard_proportion_ci.R       40       5  87.50%   63-67
R/ard_regression.R          49       0  100.00%
R/ard_ttest.R               78       0  100.00%
R/ard_wilcoxtest.R          83       0  100.00%
R/proportion_ci.R          182      28  84.62%   241, 244, 253-258, 266, 281, 381-404
TOTAL                      523      33  93.69%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  --------
R/ard_kruskaltest.R      +27       0  +100.00%
TOTAL                    +27       0  +0.34%

Results for commit: 978d067

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Unit Tests Summary

 1 files  13 suites   2s ⏱️
13 tests  9 ✅ 4 💤 0 ❌
26 runs  18 ✅ 8 💤 0 ❌

Results for commit 978d067.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
ard_kruskaltest 👶 $+0.03$ $+3$ $+1$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
ard_kruskaltest 👶 $+0.03$ ard_kurskaltest_works

Results for commit 5775ceb

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zdz2101 wow, quick turn-around! 🌟 🌟

I took a quick look with a few initial comments.

R/ard_kwtest.R Outdated Show resolved Hide resolved
R/ard_kwtest.R Outdated Show resolved Hide resolved
R/ard_kwtest.R Outdated Show resolved Hide resolved
)
})

test_that("shuffle_ard fills missing group levels if the group is meaningful", {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than testing shuffle, can we stick with as.data.frame() on the ARD table?

R/ard_kwtest.R Outdated Show resolved Hide resolved
@shajoezhu shajoezhu added the sme label Feb 8, 2024
@ddsjoberg ddsjoberg added the ARD label Feb 8, 2024
Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few final comments, thank you @zdz2101 !

R/ard_kruskaltest.R Outdated Show resolved Hide resolved
R/ard_kruskaltest.R Show resolved Hide resolved
R/ard_kruskaltest.R Outdated Show resolved Hide resolved
R/ard_kruskaltest.R Outdated Show resolved Hide resolved
tests/testthat/test-ard_kwtest.R Outdated Show resolved Hide resolved
tests/testthat/test-ard_kwtest.R Outdated Show resolved Hide resolved
@ddsjoberg
Copy link
Collaborator

hey hey @zdz2101 ! I think this PR is good to go after the updates to the snapshot tests. 1. Let's test with as.data.frame() instead of the shuffle function, and let's ensure that the data frames printed do not extend to multiple chunks

@zdz2101 zdz2101 requested a review from ddsjoberg February 14, 2024 18:41
DESCRIPTION Show resolved Hide resolved
Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zdz2101 !!

@ddsjoberg ddsjoberg merged commit 116d3df into main Feb 17, 2024
22 checks passed
@ddsjoberg ddsjoberg deleted the 38-ard-for-kruskal-wallis branch February 17, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARD for Kruskal-Wallis
3 participants