-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ard_aov
and ard_onewaytest
#44
Conversation
Code Coverage Summary
Diff against main
Results for commit: 9af5439 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 53 suites 7s ⏱️ Results for commit 9af5439. ♻️ This comment has been updated with latest results. |
- add tests - rename anova file to aov
Unit Test Performance Difference
Additional test case details
Results for commit 9f86cb4 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!! I made some initial comments, but it's getting late and i am logging off.
- Remove unnecessary function args to record. - subset columns in tests snaps for readability - more informative comment in test file.
Signed-off-by: Daniel Sjoberg <[email protected]>
on hold until #46 is complete |
Waiting on |
Signed-off-by: Daniel Sjoberg <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
+ Coverage 99.69% 99.72% +0.02%
==========================================
Files 13 15 +2
Lines 663 722 +59
==========================================
+ Hits 661 720 +59
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Daniel Sjoberg <[email protected]>
Merge branch 'main' into ard_anova # Conflicts: # NAMESPACE # _pkgdown.yml
hey @ddsjoberg! The functions have been reworked to accept the regression model at input. Let me know if there's anything else to change :) |
thank you for the updates @ayogasekaram !! I think we had a slight miscommunication. Rather than passing a full regression model, these functions should accept a formula and data frame (like the underlying functions themselves). It doesn't look like that will be a big update 🤞🏼🤞🏼🤞🏼 |
@ddsjoberg updates should be good to go! let me know if there's anything else :) |
Thank you @ayogasekaram !!! I made a few small edits
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for these additions @ayogasekaram !!!
add
ard_aov
andard_onewaytest
functions to cardxcloses #35
Reviewer Checklist (if item does not apply, mark is as complete)
devtools::install_dev_deps()
usethis::pr_merge_main()
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.devtools::test_coverage()
usethis::use_spell_check()
runs with no spelling errors in documentationWhen the branch is ready to be merged:
NEWS.md
with the changes from this pull request under the heading "# cards (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).usethis::use_version(which = "dev")
usethis::use_spell_check()
again