-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ard_regression()
#26
Conversation
Code Coverage Summary
Diff against main
Results for commit: 92af0b3 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 12 suites 1s ⏱️ Results for commit 92af0b3. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Additional test case details
Results for commit e02ec4f ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few suggestions to link the mentioned functions within the documentation. Then it should be good to go :)
Co-authored-by: Emily de la Rua <[email protected]> Signed-off-by: Daniel Sjoberg <[email protected]>
What changes are proposed in this pull request?
ard_regression()
from {cards} and made it an S3 method. I think different types of models classes will need different handling, which is why S3 is a good option here.Reviewer Checklist (if item does not apply, mark is as complete)
devtools::install_dev_deps()
usethis::pr_merge_main()
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.devtools::test_coverage()
usethis::use_spell_check()
runs with no spelling errors in documentationWhen the branch is ready to be merged:
NEWS.md
with the changes from this pull request under the heading "# cards (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).usethis::use_version(which = "dev")
usethis::use_spell_check()
again