-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Wilcoxon Rank-Sum Tests #25
Conversation
Unit Tests Summary 1 files 4 suites 1s ⏱️ Results for commit 0c4da80. ♻️ This comment has been updated with latest results. |
Code Coverage Summary
Diff against main
Results for commit: 0c4da80 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Test Performance Difference
Additional test case details
Results for commit fc63f9c ♻️ This comment has been updated with latest results. |
#' The data are then passed as | ||
#' `wilcox.test(x = data_wide[[<by level 1>]], y = data_wide[[<by level 2>]], paired = TRUE, ...)`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not allow wrapping in docs, maybe it should be on the same line somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just wondering if it was intentional that the first breaks mid-code while the second does not
Co-authored-by: Davide Garolini <[email protected]> Signed-off-by: Daniel Sjoberg <[email protected]>
Co-authored-by: Davide Garolini <[email protected]> Signed-off-by: Daniel Sjoberg <[email protected]>
Co-authored-by: Davide Garolini <[email protected]> Signed-off-by: Daniel Sjoberg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor questions from my side. Generally, it is good to go! Thanks Daniel ^^
ps: I really appreciate testing the output directly with the stats::
function. I was suggesting doing something similar some time ago to start walking the long road of addressing double programming and QCing. Going beyond this would be testing stats itself...
) | ||
} | ||
|
||
#' Convert t-test to ARD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just found this. It should be wilcox test @ddsjoberg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh goodness, thank you!
#' @inheritParams stats::wilcox.test | ||
#' @param by (`string`)\cr by column name | ||
#' @param variable (`string`)\cr variable column name | ||
#' @param ... passed to `wilcox.test(...)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing stats::
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ok to keep it like this, since it's essentially base R
What changes are proposed in this pull request?
ard_wilcoxtest()
andard_paired_wilcoxtest()
Related #42
Related #39
Reviewer Checklist (if item does not apply, mark is as complete)
devtools::install_dev_deps()
usethis::pr_merge_main()
pkgdown::build_site()
. Check the R console for errors, and review the rendered website.devtools::test_coverage()
usethis::use_spell_check()
runs with no spelling errors in documentationWhen the branch is ready to be merged:
NEWS.md
with the changes from this pull request under the heading "# cards (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).usethis::use_version(which = "dev")
usethis::use_spell_check()
again