-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning
and error
columns to ard_regression()
output
#195
Conversation
Unit Tests Summary 1 files 102 suites 1m 1s ⏱️ Results for commit 0ec71d7. ♻️ This comment has been updated with latest results. |
Unit Test Performance DifferenceAdditional test case details
Results for commit 1761a59 ♻️ This comment has been updated with latest results. |
Code Coverage Summary
Diff against main
Results for commit: 0ec71d7 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edelarua thank you for adding this! it looks great!
Just one comment on the way to set options in testthat files.
@@ -1,6 +1,8 @@ | |||
skip_if_not(do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom.helpers", reference_pkg = "cardx"))) | |||
|
|||
test_that("ard_regression_basic() works", { | |||
options(width = 100) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should be good to merge after we update this one with the withr function.
When you make this update, can you also update the NEWS and I'll merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @edelarua !!
What changes are proposed in this pull request?
warning
anderror
columns toard_regression()
output. (Adderror
andwarning
columns toard_regression()
#148)Closes #148
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()
ard_*()
function was added, it passes the ARD structural checks fromcards::check_ard_structure()
.ard_*()
function was added,set_cli_abort_call()
has been set.ard_*()
function was added and it depends on another package (such as,broom
),is_pkg_installed("broom", reference_pkg = "cardx")
has been set in the function call and the following added to the roxygen comments:@examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom"", reference_pkg = "cardx"))
devtools::test_coverage()
Reviewer Checklist (if item does not apply, mark is as complete)
devtools::test_coverage()
When the branch is ready to be merged:
NEWS.md
with the changes from this pull request under the heading "# cardx (development version)
". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.md
for examples).