Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added construct_model.survey.design() method #128

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

ddsjoberg
Copy link
Collaborator

What changes are proposed in this pull request?

  • Style this entry in a way that can be copied directly into NEWS.md. (#, @)

Provide more detail here as needed.

Reference GitHub issue associated with pull request. e.g., 'closes #'


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • If a new ard_*() function was added, it passes the ARD structural checks from cards::check_ard_structure().
  • If a new ard_*() function was added, set_cli_abort_call() has been set.
  • If a new ard_*() function was added and it depends on another package (such as, broom), is_pkg_installed("broom", reference_pkg = "cardx") has been set in the function call and the following added to the roxygen comments: @examplesIf do.call(asNamespace("cardx")$is_pkg_installed, list(pkg = "broom"", reference_pkg = "cardx"))
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cardx (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

Copy link
Contributor

badge

Code Coverage Summary

Filename                        Stmts    Miss  Cover    Missing
----------------------------  -------  ------  -------  ------------------------------------
R/ard_aod_wald_test.R              77       8  89.61%   36-41, 91, 94
R/ard_car_anova.R                  45       2  95.56%   62, 65
R/ard_car_vif.R                    61       6  90.16%   37-40, 52, 86
R/ard_effectsize_cohens_d.R        88       2  97.73%   66, 111
R/ard_effectsize_hedges_g.R        82       2  97.56%   65, 115
R/ard_proportion_ci.R              42       5  88.10%   68-72
R/ard_regression_basic.R           15       1  93.33%   46
R/ard_regression.R                 50       0  100.00%
R/ard_smd_smd.R                    55       1  98.18%   48
R/ard_stats_anova.R                95       0  100.00%
R/ard_stats_aov.R                  36       0  100.00%
R/ard_stats_chisq_test.R           39       1  97.44%   39
R/ard_stats_fisher_test.R          41       1  97.56%   39
R/ard_stats_kruskal_test.R         35       1  97.14%   38
R/ard_stats_mcnemar_test.R         49       1  97.96%   43
R/ard_stats_mood_test.R            48       1  97.92%   46
R/ard_stats_oneway_test.R          31       0  100.00%
R/ard_stats_prop_test.R            82       1  98.78%   40
R/ard_stats_t_test.R              110       2  98.18%   62, 108
R/ard_stats_wilcox_test.R          97       2  97.94%   62, 114
R/ard_survey_svychisq.R            37       1  97.30%   44
R/ard_survey_svycontinuous.R      193       2  98.96%   169, 179
R/ard_survey_svyranktest.R         51       0  100.00%
R/ard_survey_svyttest.R            50       0  100.00%
R/ard_survival_survdiff.R          89       0  100.00%
R/ard_survival_survfit.R          180       8  95.56%   79-81, 85, 95-97, 247
R/construction_helpers.R           57      20  64.91%   96-116, 143, 155-159
R/proportion_ci.R                 194      28  85.57%   290, 293, 302-307, 315, 330, 431-454
TOTAL                            2029      96  95.27%

Diff against main

Filename                    Stmts    Miss  Cover
------------------------  -------  ------  -------
R/construction_helpers.R      +15     +14  -20.80%
TOTAL                         +15     +14  -0.66%

Results for commit: 2fe3813

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

Unit Tests Summary

  1 files   60 suites   8s ⏱️
 60 tests  40 ✅ 20 💤 0 ❌
164 runs  128 ✅ 36 💤 0 ❌

Results for commit 2fe3813.

@ddsjoberg ddsjoberg merged commit 1b93221 into main Apr 19, 2024
28 checks passed
@ddsjoberg ddsjoberg deleted the more-construction branch April 19, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant