Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganize pkgdown #122

Merged
merged 5 commits into from
Apr 16, 2024
Merged

reorganize pkgdown #122

merged 5 commits into from
Apr 16, 2024

Conversation

ayogasekaram
Copy link
Contributor

@ayogasekaram ayogasekaram commented Apr 16, 2024

What changes are proposed in this pull request?
pkgdown reorganization, divide ard_*() based on package

preview:
image

closes #114


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • If a new ard_*() function was added, it passes the ARD structural checks from cards::check_ard_structure().
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • Update NEWS.md with the changes from this pull request under the heading "# cardx (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".

Copy link
Contributor

github-actions bot commented Apr 16, 2024

badge

Code Coverage Summary

Filename                        Stmts    Miss  Cover    Missing
----------------------------  -------  ------  -------  ------------------------------------
R/ard_aod_wald_test.R              77       8  89.61%   36-41, 91, 94
R/ard_car_anova.R                  45       2  95.56%   62, 65
R/ard_car_vif.R                    61       6  90.16%   37-40, 52, 86
R/ard_effectsize_cohens_d.R        88       2  97.73%   66, 111
R/ard_effectsize_hedges_g.R        82       2  97.56%   65, 115
R/ard_proportion_ci.R              42       5  88.10%   68-72
R/ard_regression_basic.R           15       1  93.33%   46
R/ard_regression.R                 50       0  100.00%
R/ard_smd_smd.R                    55       1  98.18%   48
R/ard_stats_anova.R               104      12  88.46%   120-126, 189-193
R/ard_stats_aov.R                  36       0  100.00%
R/ard_stats_chisq_test.R           39       1  97.44%   39
R/ard_stats_fisher_test.R          41       1  97.56%   39
R/ard_stats_kruskal_test.R         35       1  97.14%   38
R/ard_stats_mcnemar_test.R         49       1  97.96%   43
R/ard_stats_mood_test.R            48       1  97.92%   46
R/ard_stats_oneway_test.R          31       0  100.00%
R/ard_stats_prop_test.R            82       1  98.78%   40
R/ard_stats_t_test.R              110       2  98.18%   62, 108
R/ard_stats_wilcox_test.R          97       2  97.94%   62, 114
R/ard_survey_svychisq.R            37       1  97.30%   44
R/ard_survey_svycontinuous.R      193       2  98.96%   169, 179
R/ard_survey_svyranktest.R         51       0  100.00%
R/ard_survey_svyttest.R            50       0  100.00%
R/ard_survival_survfit.R          180       8  95.56%   78-80, 84, 94-96, 246
R/proportion_ci.R                 194      28  85.57%   290, 293, 302-307, 315, 330, 431-454
TOTAL                            1892      88  95.35%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: bce304a

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Apr 16, 2024

Unit Tests Summary

  1 files   56 suites   8s ⏱️
 56 tests  37 ✅ 19 💤 0 ❌
152 runs  117 ✅ 35 💤 0 ❌

Results for commit bce304a.

♻️ This comment has been updated with latest results.

@ayogasekaram ayogasekaram requested a review from ddsjoberg April 16, 2024 17:56
Copy link
Collaborator

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks great, thank you!! I moved {stats} to the top, since they ship with base R.

@ddsjoberg ddsjoberg merged commit 413e326 into main Apr 16, 2024
28 checks passed
@ddsjoberg ddsjoberg deleted the 114_reorg_pkgdown@main branch April 16, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_pkgdown.yaml organization... 🤔
2 participants