fix: hardware wallets are now detected using their VID #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhyslbw
reviewed
Sep 25, 2024
src/ui/app/tabs/hw.jsx
Outdated
| trezor: 'SatoshiLabs', | ||
| const VENDOR_IDS = { | ||
| ledger: [ledgerUSBVendorId], | ||
| trezor: [0x534c, 0x1209], // Model T HID 0x534c and others 0x1209 |
There was a problem hiding this comment.
Is Model T the only exception here?
There was a problem hiding this comment.
As far as I can tell looking at this:
yes
There was a problem hiding this comment.
Let's add a link to that code ref inline then to back this logic up
There was a problem hiding this comment.
Done (and squashed)
AngelCastilloB
force-pushed
the
feat/LW-11582-fix-hw-wallet-detection
branch
from
b7e9307 to
8feacce
Compare
|
mkazlauskas
approved these changes
Sep 25, 2024
rhyslbw
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardware wallet logic now looks for VID rather than manufacturer string