Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test-only failure for ghcjs #2180

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Conversation

hamishmack
Copy link
Collaborator

The new default-setup-ghcjs has a longer name than default-setup and that causes the word do to wrap onto the next line.

The expected error now looks like this for ghcjs:

Error: default-setup-ghcjs: No executables and no library found. Nothing to
do.

The new `default-setup-ghcjs` has a longer name than `default-setup` and that causes the word `do` to wrap onto the next line.

The expected error now looks like this for ghcjs:

```
Error: default-setup-ghcjs: No executables and no library found. Nothing to
do.
```
@hamishmack hamishmack requested a review from angerman April 4, 2024 04:43
@hamishmack hamishmack self-assigned this Apr 4, 2024
Copy link
Collaborator

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's consider if we should just strip newline characters and do the grep on the result? E.g. ignoring newlines altogher?

builder/comp-builder.nix Outdated Show resolved Hide resolved
@hamishmack hamishmack merged commit 2e448d1 into master Apr 4, 2024
3558 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants