Fix cabal pkg-config performance issue #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dummy version of `pkg-config` we provide to cabal-install-solver so that it can make an appropriate plan includes an extra blank line at the end of it's output. In more recent versions of cabal-install-solver the following change has been made: haskell/cabal@0b34b4e This change now filters the `null` value from the list of package names. Then when the versions are looked up the output is not the expected length (because there is also a blank line at the end of the version list). This change updates the dummy pkg-config script so that it does not include the extra blank lines at the end of the output.
pranaysashank
pushed a commit
to kronor-io/haskell.nix
that referenced
this pull request
Jan 18, 2025
The dummy version of `pkg-config` we provide to cabal-install-solver so that it can make an appropriate plan includes an extra blank line at the end of it's output. In more recent versions of cabal-install-solver the following change has been made: haskell/cabal@0b34b4e This change now filters the `null` value from the list of package names. Then when the versions are looked up the output is not the expected length (because there is also a blank line at the end of the version list). This change updates the dummy pkg-config script so that it does not include the extra blank lines at the end of the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dummy version of
pkg-configwe provide to cabal-install-solver so that it can make an appropriate plan includes an extra blank line at the end of it's output.In more recent versions of cabal-install-solver the following change has been made:
haskell/cabal@0b34b4e
This change now filters the
nullvalues from the list of package names. Then when the versions are looked up the output is not the expected length (because there is also a blank line at the end of the version list).This change updates the dummy pkg-config script so that it does not include the extra blank lines at the end of the output.