Add support for static nix-tools #2157
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nix-tools/static/outputs.nix
Outdated
| static-gmp = (final.gmp.override { withStatic = true; }).overrideDerivation (old: { | ||
| configureFlags = old.configureFlags ++ [ "--enable-static" "--disable-shared" ]; | ||
| }); | ||
| static-libblst = (final.libblst.override { enableShared = false; }).overrideDerivation (old: { |
There was a problem hiding this comment.
[diff] reported by reviewdog 🐶
| static-libblst = (final.libblst.override { enableShared = false; }).overrideDerivation (old: { | |
| static-libblst = (final.libblst.override { enableShared = false; }).overrideDerivation (_old: { |
| }; | ||
|
|
||
|
|
||
| zippedToolsNoIfdFor = fragment-name: |
There was a problem hiding this comment.
We should document this in detail, why we need this, and what the issue with keeping IFDs is, and why using recursive-nix helps us here.
nix-tools/static/project.nix
Outdated
|
|
||
| apply-hnix-patches = { | ||
| packages.hnix.patches = [ | ||
| (builtins.toFile "plutus-core.patch" '' |
There was a problem hiding this comment.
I have no idea why this is named the way it's named. I guess I will just rename it.
nix-tools/static/outputs.nix
Outdated
|
|
||
|
|
||
| static-libraries-overlay = final: _prev: { | ||
| static-libsodium-vrf = final.libsodium-vrf.overrideDerivation (old: { |
There was a problem hiding this comment.
This isn't used by nix-tools???
There was a problem hiding this comment.
I think it's used here
There was a problem hiding this comment.
You mean... where you added a series of probably unnecessary static library dependencies? We can't just randomly copy this stuff around, it has to depend on what libraries the package actually uses!
|
This PR seems to have a lot of stuff in it related to building static Cardano packages which shouldn't be at all necessary for building |
zeme-wana
force-pushed
the
static-nix-tools
branch
from
cea5dc8 to
a7f944d
Compare
I see, I can try removing all of these (except static-gmp --- I suppose we need that one) and see what happens. If it builds, then we don't need |
zeme-wana
force-pushed
the
static-nix-tools
branch
3 times, most recently
from
19dbbc3 to
5c67a95
Compare
zeme-wana
force-pushed
the
static-nix-tools
branch
2 times, most recently
from
c1a50f2 to
600297b
Compare
There was a problem hiding this comment.
This file seems to only have formatting changes. If we want to do formatting, let's do this differently, but not throw into Pull Requests.
zeme-wana
force-pushed
the
static-nix-tools
branch
from
f5d0be2 to
7c0cb47
Compare
zeme-wana
force-pushed
the
static-nix-tools
branch
from
7c0cb47 to
4e0943a
Compare
# Conflicts: # lib/cabal-project-parser.nix
Use static versions of
nix-tools. Because these form the foundation of IFDs in haskell.nix, having them as download-unpack-and-run available should speed up evaluation and IFDs significantly. Previously we dynamically built them on-demand, but that meant that not only the dependency closures were larger (including potentially build tools, ...) but also when ever there was a change to haskell.nix that invalidated the nix-tools build plan, they were re-built on demand.By decoupling both, we should be able to cut the worst-case scenario to download time + unpack time + runtime of the nix-tools.