fix: move sdk code to limit number of new deps #3259
Closed
+199
−1,461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhyslbw
approved these changes
Dec 10, 2024
DominikGuzei
approved these changes
Dec 10, 2024
szymonmaslowski
force-pushed
the
fix/lw-11966-limit-number-of-new-deps
branch
from
d1c8b50 to
9df2664
Compare
Adig0
reviewed
Dec 14, 2024
Comment on lines
+138
to
+142
| assertLength(expectedLength, target); | ||
| // eslint-disable-next-line wrap-regex | ||
| if (target.length > 0 && !/^[\da-f]+$/i.test(target)) { | ||
| throw new Error('expected hex string'); | ||
| } |
There was a problem hiding this comment.
code more readable and removes need for eslint comment
Suggested change
| assertLength(expectedLength, target); | |
| // eslint-disable-next-line wrap-regex | |
| if (target.length > 0 && !/^[\da-f]+$/i.test(target)) { | |
| throw new Error('expected hex string'); | |
| } | |
| assertLength(expectedLength, target); | |
| const isHexString = /^[\da-f]+$/i; | |
| if (target.length > 0 && !isHexString.test(target)) { | |
| throw new Error('expected hex string'); | |
| } |
Adig0
reviewed
Dec 14, 2024
Comment on lines
+145
to
+149
| export const typedHex = <T,>(value: string, length?: number): T => { | ||
| assertIsHexString(value, length); | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| return (value as any) as T; | ||
| }; |
There was a problem hiding this comment.
better to use unknown for this case imo, also complies with eslint requirements
Suggested change
| export const typedHex = <T,>(value: string, length?: number): T => { | |
| assertIsHexString(value, length); | |
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | |
| return (value as any) as T; | |
| }; | |
| export const typedHex = <T>(value: string, length?: number): T => { | |
| assertIsHexString(value, length); | |
| return value as unknown as T; | |
| }; |
|
Most probably, we are not going to include these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LW-11966
Move sdk code to limit number of new deps