Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wallet-swift based on uniffi-bindgen #207

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

eugene-babichenko
Copy link
Contributor

  • Provide a valid Swift module
  • Generate uniffi files into that Swift module
  • Provide a simple script to build a framework

TBD

  • Change variant names in PayloadTypeConfig - they conflict with Swift keywords
  • Build this framework for multiple platforms as .xcframework. Should build for iOS and sim.
  • Use the framework in Cordova plugin

@ecioppettini
Copy link
Contributor

Just adding something here.

If we add the auto-generated code to source control, I think we should also add a CI job that verifies that it is up to date, since if we upgrade uniffi (to 0.17.0) for example, the generated code would have to be regenerated too, otherwise you get an error (a runtime link error, in java).

Otherwise, we could just upload the auto-generated code to the tags/releases, but keep it out of source control.

@eugene-babichenko eugene-babichenko force-pushed the uniffi-swift branch 4 times, most recently from 68ae7bd to 2b878f5 Compare February 12, 2022 12:50
@eugene-babichenko eugene-babichenko force-pushed the uniffi-swift branch 2 times, most recently from 20bfd9d to 7e399f3 Compare February 12, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants