Add sim target to cordova ios build script #158
Conversation
| @@ -7,7 +7,7 @@ license = "MIT OR Apache-2.0" | |||
|
|
|||
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | |||
| [lib] | |||
| crate-type = [ "cdylib" ] | |||
| crate-type = [ "cdylib", "staticlib" ] | |||
There was a problem hiding this comment.
Apparently cdylib are deprecated for aarch64 builds, I added staticlib but I'm not sure If we need to remove the cdylib one.
There was a problem hiding this comment.
Hmmm, things won't work if we remove the cdylib though, as we are actually using the .so file.
I'm not sure if we can load static libraries in jni directly, so maybe we need to tweak something. I'll try to find out.
danielSanchezQ
changed the title
| @@ -52,4 +59,6 @@ def run(): | |||
|
|
|||
|
|
|||
| if __name__ == "__main__": | |||
| run() | |||
| # Set flag for emulator compatible lib | |||
| sim = "--sim" in sys.argv | |||
There was a problem hiding this comment.
so we need to have plugin builds for simulators and builds for apps? I wonder if we can compile the two and choose one at (app) build time.
There was a problem hiding this comment.
Maybe I'll have to rename the target in order to have all into one lib. Will research that.
There was a problem hiding this comment.
All right, it may not be possible, though... In that case maybe we can put a hook on cordova or something
No description provided.