Update instruction on installing the node from source #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbolymer
reviewed
Dec 5, 2023
docs/getting-started/install.md
Outdated
Comment on lines
53
to
54
| conflict: pkg-config package libsodium-any, not found in the pkg-config | ||
| database |
There was a problem hiding this comment.
Suggested change
| conflict: pkg-config package libsodium-any, not found in the pkg-config | |
| database | |
| conflict: pkg-config package libsodium-any, not found in the pkg-config database |
carbolymer
reviewed
Dec 5, 2023
docs/getting-started/install.md
Outdated
Comment on lines
62
to
70
| ``` | ||
| yum update -y && \ | ||
| yum install git diffutils gcc gcc-c++ tmux gmp-devel make tar xz wget zlib-devel libtool autoconf -y && \ | ||
| mkdir -p /root/src/ && cd /root/src && \ | ||
| curl -O https://distfiles.ariadne.space/pkgconf/pkgconf-2.0.3.tar.xz && \ | ||
| tar -xvf pkgconf-2.0.3.tar.xz && \ | ||
| cd pkgconf-2.0.3 && \ | ||
| ./configure && make && make install && \ | ||
| ``` |
There was a problem hiding this comment.
looks slightly better when indented
Suggested change
| ``` | |
| yum update -y && \ | |
| yum install git diffutils gcc gcc-c++ tmux gmp-devel make tar xz wget zlib-devel libtool autoconf -y && \ | |
| mkdir -p /root/src/ && cd /root/src && \ | |
| curl -O https://distfiles.ariadne.space/pkgconf/pkgconf-2.0.3.tar.xz && \ | |
| tar -xvf pkgconf-2.0.3.tar.xz && \ | |
| cd pkgconf-2.0.3 && \ | |
| ./configure && make && make install && \ | |
| ``` | |
| ``` | |
| yum update -y && \ | |
| yum install git diffutils gcc gcc-c++ tmux gmp-devel make tar xz wget zlib-devel libtool autoconf -y && \ | |
| mkdir -p /root/src/ && cd /root/src && \ | |
| curl -O https://distfiles.ariadne.space/pkgconf/pkgconf-2.0.3.tar.xz && \ | |
| tar -xvf pkgconf-2.0.3.tar.xz && \ | |
| cd pkgconf-2.0.3 && \ | |
| ./configure && make && make install && \ | |
| ``` |
carbolymer
reviewed
Dec 5, 2023
docs/getting-started/install.md
Outdated
|
|
||
| The possible solutions to this problem are: | ||
|
|
||
| - to upgrade `pkgconf` to version 2: |
There was a problem hiding this comment.
Suggested change
| - to upgrade `pkgconf` to version 2: | |
| - to upgrade `pkgconf` to version 2 by building it from source: |
carbolymer
approved these changes
Dec 5, 2023
ArturWieczorek
force-pushed
the
artur/update-install-instruction
branch
from
c9ac5ec to
749f03b
Compare
|
Thanks, remarks/suggestions applied and PR merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update instruction to include information about possible issue (and solutions) with
pkg-configthat user may face during installation.More here: IntersectMBO/cardano-node#5561