-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: admit longer session cookies by using a larger store #4600
Conversation
Hey @kedorlaomer |
We were using Microsoft's OIDC provider. It was sending session cookies which were larger than the default size of 4k. The backend wouldn't accept the login. Therefore, we had to increase the limit in our own fork. Note that this does not mean that 1e9 bytes of memory and/or storage are used. It is just a limit. The original example (which I'd need to dig out) used the largest positive integer 😸. EDIT: Didn't see that my PR description got truncated 😭 |
@kedorlaomer we can definitely increase the limit, I would prefer some logical value over an arbitrary one though. Something like 16k or 32k should be more than enough, shouldn't it? |
changed to 32k |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Here's the PR you were referring to btw: markbates/goth#141
Note that before releasing, we will wrap this around a feature flag which is deactivated by default, as NewFilesystemStore
is still an experimental feature. I'll tag you in the related PR. Thanks for your contribution!
Description
Add an explicit cookie store with a bigger limit so that we can accept larger session cookies. Some OIDC providers require that.
Changelog
beginAuthProviderVerification
, set a cookie storeChecklist
(Optional) Visual Changes
none