Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve tab navigation issue in Firefox #4562

Merged
merged 7 commits into from
Nov 8, 2024

Conversation

Aejkatappaja
Copy link
Contributor

@Aejkatappaja Aejkatappaja commented Oct 17, 2024

Description

  • Solving #4500
  • Improved focus management in the MiniMenu and ColorPicker components by adding a focus lock by default. This ensures that users have a smoother interaction with the menu on every web browser.

Changelog

  • Enhancement:
    • Apply focus locking by default on all browsers.
    • Changes applied on MiniMenu and ColorPicker

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

@Aejkatappaja Aejkatappaja mentioned this pull request Oct 17, 2024
@Schwehn42
Copy link
Collaborator

While the issue only applies to Firefox, it would be nice to have a general solution for this. Do you think that's possible?

@Schwehn42 Schwehn42 added the Changes Requested Changes requested by the reviewer label Nov 1, 2024
@Aejkatappaja
Copy link
Contributor Author

Aejkatappaja commented Nov 2, 2024

While the issue only applies to Firefox, it would be nice to have a general solution for this. Do you think that's possible?

b4c4cac

I enabled autofocus by default, which now ensures compatibility across all browsers, including Firefox.

Copy link
Collaborator

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please do the same for ColorPicker as well, so you select the Color by pressing enter and tab within the ColorPicker :)

@Aejkatappaja
Copy link
Contributor Author

Aejkatappaja commented Nov 4, 2024

lgtm, please do the same for ColorPicker as well, so you select the Color by pressing enter and tab within the ColorPicker :)

4736a06

@Schwehn42 Schwehn42 removed the Changes Requested Changes requested by the reviewer label Nov 7, 2024
Copy link
Collaborator

@Schwehn42 Schwehn42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for your contribution @Aejkatappaja 🫶

@Schwehn42 Schwehn42 added this pull request to the merge queue Nov 8, 2024
Merged via the queue into inovex:main with commit b55eedd Nov 8, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants