Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(elements|ino-select): add property error to display error state #424

Merged
merged 5 commits into from
Sep 27, 2021

Conversation

janivo
Copy link
Collaborator

@janivo janivo commented Sep 13, 2021

Relates to #423

Proposed Changes

  • add Property error to enable error state programmatically

@janivo
Copy link
Collaborator Author

janivo commented Sep 13, 2021

Currently, the form submission is not prevented if there is no value selected and required set ⚠️

@janivo janivo changed the title WIP: feat(elements|ino-select): add error property feat(elements|ino-select): add error property Sep 13, 2021
@janivo janivo marked this pull request as draft September 13, 2021 10:36
packages/storybook/custom-elements.json Outdated Show resolved Hide resolved
@janivo janivo marked this pull request as ready for review September 27, 2021 09:55
@janivo janivo requested a review from BenPag September 27, 2021 09:55
@janivo janivo changed the title feat(elements|ino-select): add error property feat(elements|ino-select): add property error to display error state Sep 27, 2021
@janivo janivo merged commit f3b97c6 into master Sep 27, 2021
@janivo janivo deleted the elements-ino-select-error-states branch September 27, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants