Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nessus scan module #315

Closed
wants to merge 12 commits into from
Closed

Add nessus scan module #315

wants to merge 12 commits into from

Conversation

LindseyDurst
Copy link

No description provided.

@LindseyDurst LindseyDurst self-assigned this May 31, 2023
@LindseyDurst LindseyDurst force-pushed the nessus_scan branch 3 times, most recently from 5a75d6f to 484dd59 Compare May 31, 2023 08:25
Phantuman
Phantuman reviewed May 31, 2023
View reviewed changes
Copy link

@Phantuman Phantuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also convert more uses of .format to f-strings

serveradmin/nessus/models.py Outdated Show resolved Hide resolved
serveradmin/nessus/models.py Outdated Show resolved Hide resolved
serveradmin/nessus/models.py Outdated Show resolved Hide resolved
serveradmin/nessus/models.py Outdated Show resolved Hide resolved
serveradmin/nessus/models.py Outdated Show resolved Hide resolved
serveradmin/nessus/models.py Outdated Show resolved Hide resolved
serveradmin/nessus/models.py Outdated Show resolved Hide resolved
serveradmin/nessus/models.py Outdated Show resolved Hide resolved
serveradmin/nessus/models.py Outdated Show resolved Hide resolved
serveradmin/nessus/models.py Outdated Show resolved Hide resolved
Phantuman
Phantuman reviewed Jun 1, 2023
View reviewed changes
serveradmin/nessus/models.py Outdated Show resolved Hide resolved
serveradmin/nessus/models.py Outdated Show resolved Hide resolved
serveradmin/nessus/models.py Outdated Show resolved Hide resolved
serveradmin/nessus/models.py Outdated Show resolved Hide resolved
@LindseyDurst LindseyDurst force-pushed the nessus_scan branch 2 times, most recently from b1a4f8f to b66b9c8 Compare June 2, 2023 09:03
kofrezo
kofrezo requested changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@kofrezo kofrezo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have submitted what I have so far. It misses a review of the models.py I'll have a look at this later.

serveradmin/nessus/views.py Outdated Show resolved Hide resolved
serveradmin/nessus/views.py Outdated Show resolved Hide resolved
serveradmin/nessus/views.py Outdated Show resolved Hide resolved
serveradmin/nessus/templates/nessus/nessus.html Outdated Show resolved Hide resolved
serveradmin/nessus/urls.py Outdated Show resolved Hide resolved
serveradmin/nessus/templates/nessus/nessus.html Outdated Show resolved Hide resolved
serveradmin/nessus/views.py Outdated Show resolved Hide resolved
serveradmin/nessus/views.py Outdated Show resolved Hide resolved
serveradmin/nessus/views.py Outdated Show resolved Hide resolved
serveradmin/nessus/views.py Outdated Show resolved Hide resolved
@LindseyDurst LindseyDurst force-pushed the nessus_scan branch 3 times, most recently from 6452f82 to 401262f Compare June 9, 2023 16:13
kofrezo
kofrezo requested changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@kofrezo kofrezo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. To reduce the effort I'd recommend to run black code formatter over the files.

serveradmin/nessus/models.py Outdated Show resolved Hide resolved
serveradmin/nessus/models.py Outdated Show resolved Hide resolved
serveradmin/nessus/models.py Outdated Show resolved Hide resolved
serveradmin/nessus/models.py Outdated Show resolved Hide resolved
serveradmin/nessus/models.py Outdated Show resolved Hide resolved
serveradmin/nessus/models.py Outdated Show resolved Hide resolved
serveradmin/nessus/models.py Outdated Show resolved Hide resolved
serveradmin/nessus/models.py Show resolved Hide resolved
serveradmin/nessus/models.py Outdated Show resolved Hide resolved
serveradmin/nessus/models.py Outdated Show resolved Hide resolved
@LindseyDurst LindseyDurst requested a review from kofrezo July 24, 2023 11:08
@kofrezo kofrezo changed the title WIP Add nessus scan module Add nessus scan module Sep 29, 2023
@kofrezo kofrezo force-pushed the nessus_scan branch 2 times, most recently from 1d2d5c8 to a5c1990 Compare September 29, 2023 14:00
@kofrezo
Copy link
Contributor

kofrezo commented Mar 12, 2024

Moved to internal repository containing our internal apps.

@kofrezo kofrezo closed this Mar 12, 2024
@kofrezo kofrezo deleted the nessus_scan branch March 12, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phantuman Phantuman Phantuman left review comments

@kofrezo kofrezo Awaiting requested review from kofrezo

Assignees

@LindseyDurst LindseyDurst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LindseyDurst @kofrezo @Phantuman