Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing page 115 jg #138

Merged
merged 33 commits into from
May 22, 2020
Merged

Landing page 115 jg #138

merged 33 commits into from
May 22, 2020

Conversation

JacobSNGoodwin
Copy link
Contributor

@JacobSNGoodwin JacobSNGoodwin commented May 4, 2020

Implements the react portion of #116 and uses Storybook to prototype.

I just wanted to get on of you to look at my branch to make sure there aren't any blaring issues with responsiveness. Any other comments would be gladly accepted!

Instructions

  • Run storybook with yarn storybook
  • Open the default Landing Page component
  • Check General responsiveness
  • In the Course Program slider, the whole card is a link. The slider arrow buttons to change the course still seem to work fine, even swiping on touch screens.
  • Open the actions panel to make sure the component emits onCourseSelected with the proper id when the various items in the Course Program slider are selected.
  • Check link for information requested button (at the bottom of the component) which also emits an event (can be used to navigate in nextjs page that will eventually hold this component)

Known issue:

  • Need to use a new asset for the Program image, as using a cover image doesn't work well with the logo.

saynegrojas and others added 30 commits March 10, 2020 17:36
Need some linting erros fixed in other branches
Also wrap in landing-page class to no mess with other component styles
@JacobSNGoodwin JacobSNGoodwin mentioned this pull request May 18, 2020
3 tasks
@JacobSNGoodwin JacobSNGoodwin merged commit 72656b0 into dev May 22, 2020
@JacobSNGoodwin JacobSNGoodwin deleted the landing-page-115-jg branch May 22, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants