Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement place name generators #293

Open
MikkelPaulson opened this issue Dec 6, 2022 · 7 comments
Open

Implement place name generators #293

MikkelPaulson opened this issue Dec 6, 2022 · 7 comments
Labels
enhancement Minor feature or improvement to an existing feature good first issue Good issues for first-time contributors help wanted Tasks that I can't/don't plan to do myself task list A list of work for a new feature

Comments

@MikkelPaulson
Copy link
Collaborator

MikkelPaulson commented Dec 6, 2022

Most Places still lack name generators, so the only way to create a blacksmith (for instance) is blacksmith named Blah. The only Place that currently has a generator is the Inn.

Existing implementation example: core/src/world/place/building/business/inn.rs
All recognized Places can be found in submodules of core/src/world/place

This is a tracking issue for the rather extensive list of Place types, which I won't attempt to exhaustively list here at this point. Individual issues should be created to track work done on name generators for a particular subtype.

  • Building
    • Business
      • Arena
      • Armorer
      • Bakery
      • Bank
      • Bar
      • Bathhouse
      • Blacksmith
      • Brewery
      • Casino
      • Club
      • Distillery
      • Fighting Pit
      • Food Counter
      • Forge
      • Furniture Shop
      • Furrier
      • General Store
      • Guild Hall
      • Imports Shop
      • Rewrite inn name generation #109
      • Jeweller
      • Lumberyard
      • Magic Shop
      • Mill
      • Pet Store
      • Restaurant
      • Specialty Shop
      • Spirits Shop
      • Stable
      • Textiles Shop
      • Implement theater name generator #332
      • Trading Post
      • Vault
      • Wainwright
      • Warehouse
      • Weaponsmith
      • Woodshop
    • Education
      • Academy
      • College
      • Library
      • School
      • University
    • Government
      • Court
      • Embassy
      • Guardhouse
      • Palace
      • Prison
    • Military
      • Barracks
      • Base
      • Castle
      • Citadel
      • Fort
      • Fortress
      • Keep
      • Stronghold
      • Tower
    • Religious
    • Travel
      • Bridge
      • Duty House
      • Ferry
      • Gate
      • Lighthouse
      • Market
      • Pier
      • Portal
      • Shipyard
  • Location
    • Geographical
    • Landmark
      • Farm
      • Fountain
      • Garden
      • Harbor
      • Mine
      • Monument
      • Ruin
      • Street
      • Wall
    • Settlement
      • Camp
      • Capital
      • City
      • District
      • Outpost
      • Town
  • Region
    • Geography
      • Archipelago
      • Barrens
      • Coastline
      • Continent
      • Desert
      • Forest
      • Jungle
      • Lake
      • Marsh
      • Mesa
      • Moor
      • Mountain
      • Ocean
      • Plain
      • Plateau
      • Reef
      • Sea
      • Swamp
      • Tundra
      • Wasteland
      • World
    • Political
      • Barony
      • CityState
      • Confederation
      • Country
      • County
      • Domain
      • Duchy
      • Empire
      • Kingdom
      • Nation
      • Principality
      • Province
      • Realm
      • Region
      • Territory
@MikkelPaulson MikkelPaulson added enhancement Minor feature or improvement to an existing feature task list A list of work for a new feature good first issue Good issues for first-time contributors help wanted Tasks that I can't/don't plan to do myself labels Dec 6, 2022
@MikkelPaulson MikkelPaulson changed the title Complete place name generators Implement place name generators Dec 6, 2022
@alfonsomartinezs
Copy link
Contributor

alfonsomartinezs commented Jan 17, 2023

I'd like to work on the shrine place generator

edit: I'd like to work on many of the generators, but I figured I'd start with this one since It'd be my introduction to rust

@MikkelPaulson
Copy link
Collaborator Author

@alfonsomartinezs Sure thing! If you want a guide, you can find the sole existing generator at core/src/world/place/building/business/inn.rs, although it's pretty rudimentary (not much more sophisticated than the d20 table in the DM's Guide).

There exists a description field, but it isn't yet used for anything. Generating descriptions for NPCs and Places is somewhere on my roadmap.

I've updated the ticket with a list of all entities and created a ticket for the Shrine. Please let me know if you have any questions.

@MikkelPaulson
Copy link
Collaborator Author

Spitballing re: #298:

Even with two generators roughed in, there's starting to be some overlap in vocabulary (right now, animals and I guess technically numbers). I'd like to start bubbling that overlap up, so that ideally each subsequent generator will require less and less brainstorming.

The other long-term goal I have for the place generators is for them to have alignments and wealth commensurate with the location where they are found, so in Evilton you're more likely to have a pub called The Hanged Man while in Richvale you'll encounter The Gilded Lily. Which will ultimately imply an architecture where the vocabulary generators are aware of the Demographics, and where each term has a good/evil/rich/poor weight associated with it. That seems like fodder for a future refactor rather than a premature optimization for today, however.

@ChrisRenfrow
Copy link
Contributor

Hey there, I think I'd like to try my hand at adding some generators for Location -> Geography.

Spitballing re: #298:

Even with two generators roughed in, there's starting to be some overlap in vocabulary (right now, animals and I guess technically numbers). I'd like to start bubbling that overlap up, so that ideally each subsequent generator will require less and less brainstorming.

Perhaps a very simple way to start with this might be to simply add shared constants for things like enemy and animal to DRY things up until a clear pattern emerges.

@azylko
Copy link
Contributor

azylko commented Feb 20, 2024

Hey, I am interested in working on a name generator (I am thinking theatre) as a way to start learning Rust!

@MikkelPaulson
Copy link
Collaborator Author

@azylko Sure thing! Take a look at some of the completed tasks in the list to get a sense of how the generators are set up, and don't hesitate to @ me if you have any questions.

#332

@ThinkerDreamer
Copy link

I would like to make a first version of a Blacksmith name generator. Since today is a holiday here, and I don't know how much more time I'll have for this besides today, I'll go ahead and get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Minor feature or improvement to an existing feature good first issue Good issues for first-time contributors help wanted Tasks that I can't/don't plan to do myself task list A list of work for a new feature
Projects
None yet
Development

No branches or pull requests

5 participants