Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Loc->Geo->Canyon name generator #312

Closed
ChrisRenfrow opened this issue Apr 25, 2023 · 3 comments · Fixed by #313
Closed

Implement Loc->Geo->Canyon name generator #312

ChrisRenfrow opened this issue Apr 25, 2023 · 3 comments · Fixed by #313

Comments

@ChrisRenfrow
Copy link
Contributor

See #293

@ChrisRenfrow
Copy link
Contributor Author

@MikkelPaulson I'm planning on tackling this and the remainder of the Location -> Geography name-generators this and next week, any notes before I start?

@MikkelPaulson
Copy link
Collaborator

@ChrisRenfrow Sorry for the delayed response. No notes in particular! Some kind soul has seen fit to DRY out a bunch of the vocabulary in the name generators, which should make life that much easier. ;)

Also, you don't have to keep asking for permission. I include that request in the contributing guidelines to ensure that I have a chance to properly scope a task in advance and address any questions someone might have, but you know the drill for generators by now.

@ChrisRenfrow
Copy link
Contributor Author

No worries! Also, I definitely started without waiting for your response anyway. 😆 Expect a PR for this before the end of the week.

@MikkelPaulson MikkelPaulson linked a pull request Sep 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants