minor corrections

challenger/eventhandler/challenge_test.go

@@ -35,16 +35,16 @@ func TestCheckValue(t *testing.T) {
 
 	ctx := types.NewContext(context.Background(), zap.NewNop(), "")
 
-	challenges, procesedEvents, err := eventHandler.CheckValue(ctx, checkingEvents)
+	challenges, processedEvents, err := eventHandler.CheckValue(ctx, checkingEvents)
 	require.NoError(t, err)
 
 	require.Len(t, challenges, 2)
-	require.Len(t, procesedEvents, 4)
+	require.Len(t, processedEvents, 4)
 
 	require.Equal(t, challenges[0].Id, challengertypes.ChallengeId{Type: challengertypes.EventTypeOracle, Id: 4})
 	require.Equal(t, challenges[1].Id, challengertypes.ChallengeId{Type: challengertypes.EventTypeOutput, Id: 2})
 
-	require.ElementsMatch(t, procesedEvents, append(events[:1], events[2:]...))
+	require.ElementsMatch(t, processedEvents, append(events[:1], events[2:]...))
 }
 
 func TestGetPrevPendingEvent(t *testing.T) {

challenger/eventhandler/db.go

@@ -28,7 +28,8 @@ func GetPendingEvent(db types.BasicDB, id challengertypes.ChallengeId) (challeng
 	if err != nil {
 		return nil, errors.Wrap(err, "failed to unmarshal challenge event")
 	}
-	return event, err
+
+	return event, nil
 }
 
 func SavePendingEvents(db types.BasicDB, events []challengertypes.ChallengeEvent) error {

challenger/eventhandler/db_test.go

@@ -13,7 +13,7 @@ func TestDBPendingEvent(t *testing.T) {
 	db, err := db.NewMemDB()
 	require.NoError(t, err)
 
-	event := challengertypes.NewDeposit(1, 2, "from", "to", "l1Denom", "amount", time.Unix(0, 10000))
+	event := challengertypes.NewDeposit(1, 2, "from", "to", "l1Denom", "amount", time.Unix(0, 10000).UTC())
 
 	_, err = GetPendingEvent(db, event.Id())
 	require.Error(t, err)
@@ -44,7 +44,7 @@ func TestDBPendingEvents(t *testing.T) {
 	var ids []challengertypes.ChallengeId
 
 	for i := uint64(0); i < 10; i++ {
-		event := challengertypes.NewDeposit(i, 2, "from", "to", "l1Denom", "amount", time.Unix(0, 10000))
+		event := challengertypes.NewDeposit(i, 2, "from", "to", "l1Denom", "amount", time.Unix(0, 10000).UTC())
 		events = append(events, event)
 		ids = append(ids, event.Id())
 	}

challenger/eventhandler/pending_events.go

@@ -8,6 +8,10 @@ import (
 )
 
 func (ch *ChallengeEventHandler) SetPendingEvents(events []challengertypes.ChallengeEvent) {
+	if len(events) == 0 {
+		return
+	}
+
 	ch.pendingEventsMu.Lock()
 	defer ch.pendingEventsMu.Unlock()
 
@@ -40,6 +44,7 @@ func (ch *ChallengeEventHandler) DeletePendingEvent(id challengertypes.Challenge
 	delete(ch.pendingEvents, id)
 }
 
+// get all pending oracle events that are less than toL1BlockHeight
 func (ch *ChallengeEventHandler) getOraclePendingEvents(toL1BlockHeight uint64) []challengertypes.ChallengeEvent {
 	ch.pendingEventsMu.Lock()
 	defer ch.pendingEventsMu.Unlock()

challenger/eventhandler/pending_events_test.go

@@ -16,10 +16,10 @@ func TestPendingEvent(t *testing.T) {
 	eventHandler := NewChallengeEventHandler(db)
 
 	events := []challengertypes.ChallengeEvent{
-		challengertypes.NewDeposit(1, 2, "from", "to", "l1Denom", "amount", time.Unix(0, 100)),
-		challengertypes.NewDeposit(2, 2, "from", "to", "l1Denom", "amount", time.Unix(0, 101)),
-		challengertypes.NewOracle(3, []byte("data"), time.Unix(0, 103)),
-		challengertypes.NewOracle(4, []byte("data2"), time.Unix(0, 104)),
+		challengertypes.NewDeposit(1, 2, "from", "to", "l1Denom", "amount", time.Unix(0, 100).UTC()),
+		challengertypes.NewDeposit(2, 2, "from", "to", "l1Denom", "amount", time.Unix(0, 101).UTC()),
+		challengertypes.NewOracle(3, []byte("data"), time.Unix(0, 103).UTC()),
+		challengertypes.NewOracle(4, []byte("data2"), time.Unix(0, 104).UTC()),
 	}
 
 	eventHandler.SetPendingEvents(events)

challenger/host/handler_test.go

@@ -45,6 +45,7 @@ func TestBeginBlockHandler(t *testing.T) {
 	require.NoError(t, err)
 	require.Equal(t, 1, h.stage.Len())
 
+	// clear eventQueue, outputPendingEventQueue and stage
 	err = h.beginBlockHandler(types.Context{}, nodetypes.BeginBlockArgs{})
 	require.NoError(t, err)
 

challenger/host/host.go

@@ -68,10 +68,13 @@ func (h *Host) Initialize(ctx types.Context, processedHeight int64, child childN
 	h.child = child
 	h.challenger = challenger
 
+	// fetch next l1 sequence to process, we don't need to process previous l1 sequences
+	// because they are already processed by the challenger.
 	h.initialL1Sequence, err = h.child.QueryNextL1Sequence(ctx, h.child.Height())
 	if err != nil {
 		return time.Time{}, errors.Wrap(err, "failed to query next l1 sequence")
 	}
+
 	h.registerHandlers()
 
 	err = h.eventHandler.Initialize(bridgeInfo.BridgeConfig.SubmissionInterval)