feat: update ante handler to allow authz message #81
Conversation
WalkthroughThe pull request involves updates to the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
go.mod (1)
Line range hint
3-5: Critical: Invalid Go version configurationThere are several issues with the Go version configuration:
- The module's Go version (1.22.7) is lower than the toolchain version (1.23.0)
- Go 1.23.0 doesn't exist yet (latest stable version is 1.22.1 as of April 2024)
Apply this fix:
-go 1.22.7 - -toolchain go1.23.0 +go 1.22.1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod(1 hunks)
🔇 Additional comments (2)
go.mod (2)
Line range hint 284-297: Verify the necessity of custom replacements
The replace directives point to custom forks, particularly noting a pending PR in cometbft-client. Let's verify if these custom replacements are still necessary.
✅ Verification successful
Custom replacements still necessary due to pending upstream changes
The verification shows that:
- The PR in strangelove-ventures/cometbft-client (fix: bridge hook to check sender addr #10) is still open and unmerged since September 2024
- The custom fork of cometbft is actively maintained (last commit: Nov 13, 2024)
- The custom fork of cometbft-client contains necessary changes pending upstream merge
The replace directives are currently necessary to:
- Use required dependency versions not yet available upstream
- Work around the grpc version compatibility issue with cosmos/relayer
- Maintain compatibility with custom changes in the cometbft fork
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify status of mentioned PR and necessity of custom forks
# Check if the PR in strangelove-ventures/cometbft-client is still open
gh api repos/strangelove-ventures/cometbft-client/pulls/10
# Check last commit dates of custom forks to ensure they're actively maintained
for repo in cometbft ibc-go/v8 cometbft-client; do
echo "Checking $repo..."
gh api repos/initia-labs/$repo/commits/HEAD | jq -r '.commit.author.date'
done
Length of output: 17710
38-38: Verify OPinit version compatibility
Let's verify that v0.6.1 of OPinit exists and contains the required ante handler changes.
Description
Bump OPinit to allow authz message to system lane and check fee granter when we check fee whitelist in free lane.
initia-labs/OPinit#126
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
github.com/initia-labs/OPinitmodule version from 0.6.0 to 0.6.1.