Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade: prepare upgrade #80

Merged
merged 2 commits into from
Nov 15, 2024
Merged

upgrade: prepare upgrade #80

merged 2 commits into from
Nov 15, 2024

Conversation

beer-1
Copy link
Contributor

@beer-1 beer-1 commented Nov 15, 2024

Description

add missing opchild ante


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced ante handler with stricter dependency requirements and additional validation checks.
    • Introduced a new decorator for the OPChild module.
  • Bug Fixes

    • Improved error handling in the ante handler to ensure all required components are validated.
  • Updates

    • Upgraded the application version from 0.6.2 to 0.6.3, with changes to the HookMaxGas parameter logic.
    • Updated dependencies to the latest versions, including github.com/initia-labs/OPinit and its API counterpart.

@beer-1 beer-1 self-assigned this Nov 15, 2024
@beer-1 beer-1 requested a review from a team as a code owner November 15, 2024 08:56
Copy link

coderabbitai bot commented Nov 15, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces several modifications to the ante package, specifically in app/ante/ante.go, where the HandlerOptions struct's field types for OPChildKeeper and AuctionKeeper have been changed to pointers. The NewAnteHandler function now includes additional error checks for these keepers and the IBCkeeper. The setupBlockSDK function in app/blocksdk.go has been updated to pass the AuctionKeeper directly rather than dereferencing it. The upgrade version in app/upgrade.go has been incremented from "0.6.2" to "0.6.3", with changes to how HookMaxGas is set. The go.mod file reflects updates to dependency versions.

Changes

File Change Summary
app/ante/ante.go Updated HandlerOptions struct to use pointers for OPChildKeeper and AuctionKeeper. Enhanced error checks in NewAnteHandler.
app/blocksdk.go Modified setupBlockSDK to pass AuctionKeeper directly instead of dereferencing it.
app/upgrade.go Updated upgrade version from "0.6.2" to "0.6.3". Changed HookMaxGas assignment logic to be conditional.
go.mod Updated dependency versions for github.com/initia-labs/OPinit and its API from v0.5.7 to v0.6.0. Toolchain updated to go1.23.0.

Possibly related PRs

  • bump opinit and cleanup github actions #59: The changes in app/blocksdk.go regarding the AuctionKeeper parameter directly relate to the modifications made in the main PR's NewAnteHandler function, which also involves the AuctionKeeper.
  • feat: refactor app struct #60: The refactor of the application structure in this PR may impact the overall handling of keepers, including the AuctionKeeper and OPChildKeeper, which are central to the main PR's changes.
  • bump wasm versions #62: The updates to the go.mod file in this PR include version changes for dependencies that may indirectly affect the functionality of the ante package, particularly if those dependencies are related to the keepers used in the main PR.
  • bump deps #78: This PR's updates to dependencies may include changes that affect the ante package or its related components, which are also modified in the main PR.

🐇 In the meadow, changes bloom,
Ante handlers shed old gloom.
Keepers now are pointers bright,
Error checks bring clearer light.
Upgrades dance from two to three,
A hop towards stability! 🌼

Warning

Rate limit exceeded

@beer-1 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 27 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 0a50ef0 and 91cb116.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@sh-cha sh-cha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 11.76471% with 15 lines in your changes missing coverage. Please review.

Project coverage is 64.37%. Comparing base (dbee224) to head (91cb116).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
app/ante/ante.go 10.00% 6 Missing and 3 partials ⚠️
app/upgrade.go 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
- Coverage   64.56%   64.37%   -0.19%     
==========================================
  Files          39       39              
  Lines        3217     3228      +11     
==========================================
+ Hits         2077     2078       +1     
- Misses        965      972       +7     
- Partials      175      178       +3     
Files with missing lines Coverage Δ
app/blocksdk.go 94.28% <100.00%> (ø)
app/upgrade.go 18.75% <0.00%> (-1.25%) ⬇️
app/ante/ante.go 53.16% <10.00%> (-6.26%) ⬇️

@beer-1 beer-1 merged commit 74021de into main Nov 15, 2024
11 of 13 checks passed
@beer-1 beer-1 deleted the release/v0.6.3 branch November 15, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants