add spellcheck and run #79
Conversation
WalkthroughThis pull request introduces several changes aimed at enhancing spell-checking processes and improving code clarity. A new Changes
Possibly related PRs
Poem
Warning Rate limit exceeded@Vritra4 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 20 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
=======================================
Coverage 64.56% 64.56%
=======================================
Files 39 39
Lines 3217 3217
=======================================
Hits 2077 2077
Misses 965 965
Partials 175 175
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (2)
.github/workflows/spellcheck.yml (2)
3-5: Consider adding more trigger eventsThe workflow currently only runs on pull requests. Consider adding:
pushevent for main/master branch to catch typos in direct pushesworkflow_dispatchfor manual runs when neededon: pull_request: + push: + branches: [ main, master ] + workflow_dispatch:
7-9: Add timeout configurationConsider adding a timeout to prevent hung jobs from consuming unnecessary minutes.
spellcheck: runs-on: ubuntu-latest + timeout-minutes: 10
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (6)
.github/config/.codespellignore(1 hunks).github/workflows/spellcheck.yml(1 hunks)Dockerfile.arm64(1 hunks)app/keepers/keepers.go(1 hunks)contrib/devtools/Makefile(2 hunks)shared.Dockerfile(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- .github/config/.codespellignore
- Dockerfile.arm64
- contrib/devtools/Makefile
- shared.Dockerfile
🔇 Additional comments (6)
.github/workflows/spellcheck.yml (2)
10-11: LGTM!
Using the latest major version of actions/checkout is good practice.
16-16: Verify .codespellignore file setup
The workflow references .github/config/.codespellignore, but we need to verify its existence and format.
✅ Verification successful
Codespell ignore file exists and is properly formatted
The .github/config/.codespellignore file exists and contains a valid list of words to be ignored by the spellchecker, one word per line. The format is correct and matches the expected structure for codespell ignore files.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if .codespellignore exists and is properly formatted
if [ -f ".github/config/.codespellignore" ]; then
echo "Found .codespellignore file"
cat ".github/config/.codespellignore"
else
echo "Error: .codespellignore file not found"
# Check if it exists in other locations
find . -name ".codespellignore" -type f
fi
Length of output: 249
app/keepers/keepers.go (4)
247-247: LGTM: Typo fix in comment
The spelling correction from "propogated" to "propagated" is accurate.
Line range hint 247-262: LGTM: Proper keeper initialization and hook configuration
The initialization sequence is correct:
- MarketMapKeeper is properly configured with OracleKeeper hooks
- OPChildKeeper is initialized with all required dependencies
- Authority address configuration is consistent
The hook configuration ensures that new market map entries are properly propagated to the oracle keeper.
Line range hint 702-711: LGTM: Secure Wasm query configuration
The Wasm query configuration implements proper security measures:
- Query allowlist is correctly configured for specific oracle queries
- Proto message types are explicitly defined for allowed queries
- Stargate querier is restricted to the allowlist
This implementation follows security best practices by limiting the attack surface through explicit allowlisting.
Line range hint 439-474: Verify IBC middleware stack configuration
The IBC middleware stack is configured with multiple layers. Please verify:
- The ordering of middleware matches the security requirements
- All necessary middleware hooks are properly connected
- The sequence handles both Send and Receive paths correctly:
- Send: transfer -> packet forward -> rate limit -> fee -> channel
- Receive: channel -> fee -> wasm -> rate limit -> packet forward -> forwarding -> transfer
✅ Verification successful
Based on the shell script results, I can now verify the IBC middleware stack configuration. Let me generate the final response:
IBC middleware stack configuration is correctly ordered and connected
The verification confirms that the middleware stack is properly configured with the correct ordering for both Send and Receive paths:
- Transfer stack:
- Receive path: fee -> wasm -> rate limit -> packet forward -> forwarding -> transfer (verified in code)
- Send path: transfer -> packet forward -> rate limit -> fee -> channel (verified in ICS4wrapper comment)
- ICA stacks:
- Both host and controller modules are properly wrapped with fee middleware
- Wasm stack:
- Receive path: fee -> hook -> wasm (verified in code)
The middleware ordering follows security best practices by ensuring fee middleware is the outermost layer and maintaining consistent ordering between send and receive paths.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify IBC middleware configuration
# Look for any potential middleware ordering issues or missing connections
# Check for middleware initialization order
rg -A 5 "NewIBCMiddleware|NewMiddleware"
# Verify all required IBC hooks are properly connected
ast-grep --pattern 'SetHooks($hook)'
Length of output: 3523
Description
similar with initia`s, add a workflow to check spell
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
New Features
.codespellignorefile to specify terms to be ignored during spell-checking.Bug Fixes
Chores