Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: guarantee ack & timeout to be sccuess #45

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

beer-1
Copy link
Member

@beer-1 beer-1 commented Jun 14, 2024

No description provided.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 38.70968% with 38 lines in your changes missing coverage. Please review.

Project coverage is 13.88%. Comparing base (0d52de4) to head (b8653b3).
Report is 2 commits behind head on main.

Files Patch % Lines
app/ibc-hooks/ack.go 37.50% 18 Missing and 2 partials ⚠️
app/ibc-hooks/timeout.go 40.00% 16 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   13.79%   13.88%   +0.08%     
==========================================
  Files          56       56              
  Lines       17968    18003      +35     
==========================================
+ Hits         2479     2499      +20     
- Misses      15294    15309      +15     
  Partials      195      195              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beer-1 beer-1 merged commit b095651 into main Jun 14, 2024
6 checks passed
@beer-1 beer-1 deleted the fix/guarantee-ack-timeout-success branch June 14, 2024 04:56
hallazzang added a commit to milkyway-labs/milkyway that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant