Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/rollback #15

Merged
merged 6 commits into from
Apr 15, 2024
Merged

Feat/rollback #15

merged 6 commits into from
Apr 15, 2024

Conversation

sh-cha
Copy link
Contributor

@sh-cha sh-cha commented Mar 29, 2024

No description provided.

@sh-cha sh-cha requested a review from beer-1 March 29, 2024 07:19
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 24.65%. Comparing base (89d2a0c) to head (f941875).
Report is 6 commits behind head on main.

Files Patch % Lines
app/app.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   22.37%   24.65%   +2.27%     
==========================================
  Files          33       34       +1     
  Lines        7553     7573      +20     
==========================================
+ Hits         1690     1867     +177     
+ Misses       5749     5550     -199     
- Partials      114      156      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

app/executor_change.go Outdated Show resolved Hide resolved
Copy link
Contributor

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beer-1 beer-1 merged commit 0ef362c into main Apr 15, 2024
6 checks passed
@beer-1 beer-1 deleted the feat/rollback branch April 15, 2024 02:34
@sh-cha sh-cha self-assigned this Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants