Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cometbft and use latest iavl #82

Merged
merged 1 commit into from
Dec 27, 2024
Merged

chore: bump cometbft and use latest iavl #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,6 @@ replace (
// use cosmos fork of keyring
github.com/99designs/keyring => github.com/cosmos/keyring v1.2.0

// Use latest iavl version to fix working hash issue for initial version.
github.com/cosmos/iavl => github.com/cosmos/iavl v1.1.4

// dgrijalva/jwt-go is deprecated and doesn't receive security updates.
// TODO: remove it: https://github.com/cosmos/cosmos-sdk/issues/13134
github.com/dgrijalva/jwt-go => github.com/golang-jwt/jwt/v4 v4.4.2
Expand All @@ -279,7 +276,7 @@ replace (

// initia custom
replace (
github.com/cometbft/cometbft => github.com/initia-labs/cometbft v0.0.0-20241217032826-9bad4b012b88
github.com/cometbft/cometbft => github.com/initia-labs/cometbft v0.0.0-20241224101634-a905db74416a
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Update dependency: upstream PR is merged but fork is still in use

The upstream PR (strangelove-ventures/cometbft-client#10) is now closed/merged, but the codebase is still using a custom fork. Consider updating to use the official release v0.1.0 which is already listed as a requirement, by removing these lines from go.mod:

  • The replace directive: github.com/strangelove-ventures/cometbft-client => github.com/initia-labs/cometbft-client v0.0.0-20240924071428-ef115cefa07e
  • The comment: // - https://github.com/strangelove-ventures/cometbft-client/pull/10
🔗 Analysis chain

Check status of pending upstream PR

There's a dependency on a custom fork of cometbft-client due to a pending upstream PR: strangelove-ventures/cometbft-client#10

Let's check if the PR is still pending:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if the upstream PR is still open

# Check PR status
gh api repos/strangelove-ventures/cometbft-client/pulls/10 --jq '.state'

# If closed, we should update the comment to remove the custom fork

Length of output: 79

Script:

#!/bin/bash
# Since the PR is closed, let's check if the dependency is still using the fork in go.mod
rg "github.com/strangelove-ventures/cometbft-client" go.mod

Length of output: 323

github.com/cosmos/ibc-go/v8 => github.com/initia-labs/ibc-go/v8 v8.0.0-20240802003717-19c0b4ad450d

// use custom version until this PR is merged
Expand Down
8 changes: 4 additions & 4 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -997,8 +997,8 @@ github.com/cosmos/gogogateway v1.2.0/go.mod h1:iQpLkGWxYcnCdz5iAdLcRBSw3h7NXeOkZ
github.com/cosmos/gogoproto v1.4.2/go.mod h1:cLxOsn1ljAHSV527CHOtaIP91kK6cCrZETRBrkzItWU=
github.com/cosmos/gogoproto v1.7.0 h1:79USr0oyXAbxg3rspGh/m4SWNyoz/GLaAh0QlCe2fro=
github.com/cosmos/gogoproto v1.7.0/go.mod h1:yWChEv5IUEYURQasfyBW5ffkMHR/90hiHgbNgrtp4j0=
github.com/cosmos/iavl v1.1.4 h1:Z0cVVjeQqOUp78/nWt/uhQy83vYluWlAMGQ4zbH9G34=
github.com/cosmos/iavl v1.1.4/go.mod h1:vCYmRQUJU1wwj0oRD3wMEtOM9sJNDP+GFMaXmIxZ/rU=
github.com/cosmos/iavl v1.2.2 h1:qHhKW3I70w+04g5KdsdVSHRbFLgt3yY3qTMd4Xa4rC8=
github.com/cosmos/iavl v1.2.2/go.mod h1:GiM43q0pB+uG53mLxLDzimxM9l/5N9UuSY3/D0huuVw=
github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v8 v8.0.2 h1:dyLNlDElY6+5zW/BT/dO/3Ad9FpQblfh+9dQpYQodbA=
github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v8 v8.0.2/go.mod h1:82hPO/tRawbuFad2gPwChvpZ0JEIoNi91LwVneAYCeM=
github.com/cosmos/ibc-apps/modules/rate-limiting/v8 v8.0.0 h1:AQO9NIAP3RFqvBCj7IqM/V1LCxmuvcvGUdu0RIEz/c0=
Expand Down Expand Up @@ -1421,8 +1421,8 @@ github.com/initia-labs/OPinit v0.6.2 h1:XGf++xIKhLSZS+y7S05pnHiAAuG2GrZuh12noN0m
github.com/initia-labs/OPinit v0.6.2/go.mod h1:e+ASISXctMJE2Tw2zisNWIEVnxgV9SogZHoZddcgg2w=
github.com/initia-labs/OPinit/api v0.6.2 h1:nU9Rv5s/6WbV3CfmNnW3MSSmqpk7Avgfd68qMWjYD08=
github.com/initia-labs/OPinit/api v0.6.2/go.mod h1:gHK6DEWb3/DqQD5LjKirUx9jilAh2UioXanoQdgqVfU=
github.com/initia-labs/cometbft v0.0.0-20241217032826-9bad4b012b88 h1:2Yyi0bjpaqFFCWN1ey0KeE/9piGPP4PIipb4+cEvSCc=
github.com/initia-labs/cometbft v0.0.0-20241217032826-9bad4b012b88/go.mod h1:9Jv7s3Z8ukB0YpH4P6PrsL5DVadnoIIL9XDToIinx9A=
github.com/initia-labs/cometbft v0.0.0-20241224101634-a905db74416a h1:qQP2cQhsZ+YyPJ0aayQr/LVva+3TbhSaBnplj0etnF8=
github.com/initia-labs/cometbft v0.0.0-20241224101634-a905db74416a/go.mod h1:9Jv7s3Z8ukB0YpH4P6PrsL5DVadnoIIL9XDToIinx9A=
github.com/initia-labs/cometbft-client v0.0.0-20240924071428-ef115cefa07e h1:k+pg63SFozCAK4LZFSiZtof6z69Tlu0O/Zftj1aAwes=
github.com/initia-labs/cometbft-client v0.0.0-20240924071428-ef115cefa07e/go.mod h1:aVposiPW9FOUeAeJ7JjJRdE3g+L6i8YDxFn6Cv6+Az4=
github.com/initia-labs/ibc-go/v8 v8.0.0-20240802003717-19c0b4ad450d h1:TLq8lB1PtQ0pjGf+bN8YgGVeLMuytZ26SBGMOs1seKY=
Expand Down
Loading