Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump cometbft to enable exit on invalid block #108

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

beer-1
Copy link
Member

@beer-1 beer-1 commented Nov 13, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Chores
    • Updated Go toolchain from version 1.22.7 to 1.23.0 for improved compatibility.
    • Modified dependency versions for cometbft, ibc-go, and go-ethereum to ensure alignment with the latest updates and custom versions.

@beer-1 beer-1 self-assigned this Nov 13, 2024
@beer-1 beer-1 requested a review from a team as a code owner November 13, 2024 07:25
Copy link

coderabbitai bot commented Nov 13, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve updates to the go.mod files for both the main module and the integration-tests module. The Go toolchain version has been updated from go1.22.7 to go1.23.0. Several dependencies have been modified, including updates to the cometbft, ibc-go, and go-ethereum packages, with some dependencies redirected to custom versions under the initia-labs namespace. The modifications ensure compatibility with the latest features and fixes while maintaining the existing indirect dependencies.

Changes

File Change Summary
go.mod - Toolchain updated to go1.23.0
- github.com/cometbft/cometbft updated from v0.0.0-20241104064728-ef8cadf1bed8 to v0.0.0-20241113064430-a371e2dc387f
- github.com/cosmos/ibc-go/v8 updated to github.com/initia-labs/ibc-go/v8 v8.0.0-20240802003717-19c0b4ad450d
- github.com/ethereum/go-ethereum updated to github.com/initia-labs/evm v0.0.0-20241108055119-3d312736d7fb
integration-tests/go.mod - Toolchain updated to go1.23.0
- github.com/cometbft/cometbft updated from v0.0.0-20241104064728-ef8cadf1bed8 to v0.0.0-20241113064430-a371e2dc387f
- github.com/cosmos/ibc-go/v8 updated to a custom version under initia-labs
- github.com/ethereum/go-ethereum redirected to a custom version

Possibly related PRs

  • feat: track latest 256 cosmos block hashes #76: The changes in the go.mod file of the main PR are related to the updates in the integration-tests/go.mod file, as both PRs involve modifications to the Go toolchain version and updates to the same dependencies, specifically github.com/cometbft/cometbft and github.com/cosmos/ibc-go/v8.

Poem

🐰 In the land of code where bunnies play,
Dependencies updated, hip-hip-hooray!
With Go toolchain fresh and bright,
Our modules leap to new heights.
Cometbft and IBC, oh what a sight!
Hopping along, everything feels right! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@beer-1 beer-1 merged commit 3264f25 into main Nov 13, 2024
2 of 5 checks passed
@beer-1 beer-1 deleted the feat/add-config-to-exit-on-invalid-block branch November 13, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant