fix bug not parsing address and minor refactor

[Vritra4]

• fix not parsing address bug
• minor refactor

Summary by CodeRabbit

• New Features

  • Improved address extraction logic from Ethereum logs, allowing for more flexible handling of varying log structures.

• Bug Fixes

  • Enhanced error handling in address conversion, ensuring that errors are correctly identified and reported.

[coderabbitai]

Walkthrough

The pull request introduces significant modifications to the extractAddressesFromEVMLog function in submodules/evm-tx/collect.go, improving the logic for extracting addresses from Ethereum logs. It dynamically checks the length of log.Topics and introduces a loop for flexible address extraction. Additionally, the error handling in the convertContractAddressToBech32 function in submodules/evm-tx/util.go is modified to ensure proper handling of conversion errors.

Changes

Files	Change Summary
submodules/evm-tx/collect.go, submodules/evm-tx/util.go	Enhancements to address extraction logic in collect.go and improved error handling in util.go.

Possibly related PRs

• add evm-tx submodules and minor improvement for plain tx #57: Introduces the extractAddressesFromEVMLog function, related to the current PR's modifications.
• collect addresses fromt transfer topic #61: Modifies the extractAddressesFromEVMLog function to return multiple addresses, closely aligning with the current PR's changes.

Poem

🐇 In the code where the logs do flow,
Addresses dance, now they gleam and glow.
With loops and checks, they’re found with ease,
A hop, a skip, like a gentle breeze.
Errors handled, no more fright,
Our code's a garden, blooming bright! 🌼

Tip

Announcements

• The review status is no longer posted as a separate comment when there are no actionable or nitpick comments. In such cases, the review status is included in the walkthrough comment.
• We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.
• Possibly related PRs: Walkthrough comment now includes a list of potentially related PRs to help you recall past context. Please share any feedback in the discussion post on our Discord.
• Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs in the walkthrough comment. You can also provide custom labeling instructions in the UI or configuration file.
• Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 144ed45 and 55f0eea.

Files selected for processing (2)

• submodules/evm-tx/collect.go (3 hunks)
• submodules/evm-tx/util.go (1 hunks)

Additional comments not posted (2)

submodules/evm-tx/util.go (1)

56-58: LGTM!

The change improves the error handling logic in the convertContractAddressToBech32 function. It now correctly handles the case where an error occurs during the conversion process by checking if the error is not nil. This ensures that the function only proceeds to return the converted address when the conversion is successful, enhancing the robustness of the function.

submodules/evm-tx/collect.go (1)

162-183: LGTM!

The changes to the extractAddressesFromEVMLog function significantly improve the logic for extracting addresses from Ethereum logs. The function is now more robust and flexible, making it adaptable to varying log structures.

Key improvements:

• The fixed length dependency on lenTransferTopic has been removed, and the function now checks the length of log.Topics dynamically.
• Early returns have been added to handle cases where log.Topics is nil or has insufficient data for address extraction.
• The check for the transfer topic has been modified to return early if the first topic does not match transferTopic.
• A loop has been introduced to iterate over the topics starting from index 1, allowing for a more flexible extraction of addresses. The loop includes a condition to break if the index reaches 3, indicating that the topic at that index represents the amount rather than an address.

These changes enhance the function's ability to handle varying log structures and ensure that it doesn't cause errors when fewer than three topics are present.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[joon9823]

LGTM