Allow other operations for tx search api #75
Conversation
|
Warning Rate limit exceeded@joon9823 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 8 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes involve modifications to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/client/lcd/api/TxAPI.ts (2 hunks)
Additional context used
Biome
src/client/lcd/api/TxAPI.ts
[error] 533-533: Avoid the delete operator which can impact performance.
Unsafe fix: Use an undefined assignment instead.
(lint/performance/noDelete)
Additional comments not posted (3)
src/client/lcd/api/TxAPI.ts (3)
189-189: LGTM!The
TxSearchOptype definition is correct and aligns with the PR objectives.
190-196: LGTM!The updated
TxSearchOptionsinterface correctly incorporates the newopfield, enhancing the flexibility of transaction searches.
532-532: LGTM!The code correctly appends the query string to the
paramsobject.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/client/lcd/api/TxAPI.ts (2 hunks)
Additional context used
Biome
src/client/lcd/api/TxAPI.ts
[error] 533-533: Avoid the delete operator which can impact performance.
Unsafe fix: Use an undefined assignment instead.
(lint/performance/noDelete)
Additional comments not posted (6)
src/client/lcd/api/TxAPI.ts (6)
189-190: LGTM!The
TxSearchOptype definition is correct and enhances the flexibility of the query options.
192-196: LGTM!The
TxSearchOptionsinterface update is correct and aligns with the newTxSearchOptype definition.
524-530: Add validation forkeyandvaluefields.The
reducefunction correctly processes each query object, but it lacks validation for thekeyandvaluefields. Consider adding validation to ensure they are not empty or invalid.Apply this diff to add validation:
const query: string = (options.query ?? []).reduce((str, q) => { + if (!q.key || !q.value) { + throw new Error('Invalid query: key and value must be provided') + } const op = q.op ?? '=' const value = q.key === 'tx.height' ? `${q.value}` : `'${q.value}'` const queryStr = op === 'EXISTS' ? `${q.key} ${op}` : `${q.key} ${op} ${value}` return str ? `${str} AND ${queryStr}` : queryStr }, '')
532-533: Avoid using thedeleteoperator.Using the
deleteoperator can impact performance. Consider setting the property toundefinedinstead.Apply this diff to avoid using the
deleteoperator:if (query) params.append('query', query) -delete options['query'] +options['query'] = undefinedTools
Biome
[error] 533-533: Avoid the delete operator which can impact performance.
Unsafe fix: Use an undefined assignment instead.
(lint/performance/noDelete)
536-536: LGTM!The loop correctly appends other options to the
paramsobject.
Line range hint
538-548: LGTM!The return statement correctly processes the search result.
Tools
Biome
[error] 533-533: Avoid the delete operator which can impact performance.
Unsafe fix: Use an undefined assignment instead.
(lint/performance/noDelete)
the above tx search condition can be queried as below
Summary by CodeRabbit
New Features
Refactor