Fix to handle metadata amino fields as undefined

initia-labs · May 22, 2024 · acab3a6 · acab3a6
1 parent aedd4a6
commit acab3a6
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 16 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@initia/initia.js",
-  "version": "0.2.2",
+  "version": "0.2.3",
   "description": "The JavaScript SDK for Initia",
   "license": "MIT",
   "author": "InitiaLabs",

diff --git a/src/core/gov/msgs/MsgSubmitProposal.ts b/src/core/gov/msgs/MsgSubmitProposal.ts
@@ -51,7 +51,7 @@ export class MsgSubmitProposal extends JSONSerializable<
       messages.map(Msg.fromAmino),
       Coins.fromAmino(initial_deposit),
       proposer,
-      metadata,
+      metadata ?? '',
       title,
       summary,
       expedited
@@ -75,7 +75,7 @@ export class MsgSubmitProposal extends JSONSerializable<
         messages: messages.map(msg => msg.toAmino()),
         initial_deposit: initial_deposit.toAmino(),
         proposer,
-        metadata,
+        metadata: metadata && metadata !== '' ? metadata : undefined,
         title,
         summary,
         expedited,
@@ -183,7 +183,7 @@ export namespace MsgSubmitProposal {
       messages: Msg.Amino[];
       initial_deposit: Coins.Amino;
       proposer: AccAddress;
-      metadata: string;
+      metadata?: string;
       title: string;
       summary: string;
       expedited: boolean;

diff --git a/src/core/gov/msgs/MsgVote.ts b/src/core/gov/msgs/MsgVote.ts
@@ -32,7 +32,12 @@ export class MsgVote extends JSONSerializable<
     const {
       value: { proposal_id, voter, option, metadata },
     } = data;
-    return new MsgVote(Number.parseInt(proposal_id), voter, option, metadata);
+    return new MsgVote(
+      Number.parseInt(proposal_id),
+      voter,
+      option,
+      metadata ?? ''
+    );
   }
 
   public toAmino(): MsgVote.Amino {
@@ -43,7 +48,7 @@ export class MsgVote extends JSONSerializable<
         proposal_id: proposal_id.toString(),
         voter,
         option,
-        metadata,
+        metadata: metadata && metadata !== '' ? metadata : undefined,
       },
     };
   }
@@ -105,7 +110,7 @@ export namespace MsgVote {
       proposal_id: string;
       voter: AccAddress;
       option: VoteOption;
-      metadata: string;
+      metadata?: string;
     };
   }
 

diff --git a/src/core/gov/msgs/MsgVoteWeighted.ts b/src/core/gov/msgs/MsgVoteWeighted.ts
@@ -36,7 +36,7 @@ export class MsgVoteWeighted extends JSONSerializable<
       Number.parseInt(proposal_id),
       voter,
       options.map(o => WeightedVoteOption.fromAmino(o)),
-      metadata
+      metadata ?? ''
     );
   }
 
@@ -48,7 +48,7 @@ export class MsgVoteWeighted extends JSONSerializable<
         proposal_id: proposal_id.toFixed(),
         voter,
         options: options.map(o => o.toAmino()),
-        metadata,
+        metadata: metadata && metadata !== '' ? metadata : undefined,
       },
     };
   }
@@ -112,7 +112,7 @@ export namespace MsgVoteWeighted {
       proposal_id: string;
       voter: AccAddress;
       options: WeightedVoteOption.Amino[];
-      metadata: string;
+      metadata?: string;
     };
   }