add metadata on schema #8
Conversation
|
is it valid? seems very different with other properties |
chain.schema.json
Outdated
| }, | ||
| "additionalProperties": false | ||
| }, | ||
| "description": "[Optional] The list of denoms and their respective amounts that are allowed to be transferred without fees." |
There was a problem hiding this comment.
A list that outlines various coin amounts. Each coin amount, denoted by the denomination (denom) and the amount, establishes a balance threshold where transaction fees are exempted. If a user's balance meets or surpasses any of these coin amounts, transaction fees will not be applied.
There was a problem hiding this comment.
rewrite description like A list specifying coin amounts by denomination that exempt users from transaction fees when their balance meets or exceeds these amounts.
devnets/mahalo/assetlist.json
Outdated
| @@ -21,13 +21,13 @@ | |||
| "coingecko_id": "", | |||
| "images": [ | |||
| { | |||
| "png": "https://raw.githubusercontent.com/initia/initia-registry/main/mahalo/images/INIT.png", | |||
| "svg": "https://raw.githubusercontent.com/initia/initia-registry/main/mahalo/images/INIT.svg" | |||
| "png": "https://raw.githubusercontent.com/initia-labs/initia-registry/main/devnets/mahalo/images/ETH-INIT.png", | |||
chain.schema.json
Outdated
| @@ -539,6 +539,12 @@ | |||
| "$ref": "#/$defs/endpoint" | |||
| } | |||
| }, | |||
| "faucet": { | |||
There was a problem hiding this comment.
This seems saying faucet site not faucet api.
how about change this to faucet_api?
There was a problem hiding this comment.
afaik faucet-api won't be exposed to public. i think we need to fix values.
There was a problem hiding this comment.
because the object key is apis (not urls) so i think faucet means the faucet api already.
There was a problem hiding this comment.
any thought? @Vritra4
There was a problem hiding this comment.
let's move it to next to explorer as we discussed lol
There was a problem hiding this comment.
@JSHan94 fix values of faucet. no -api.
There was a problem hiding this comment.
we decided to remove faucet api from the schema and add faucet websites in the same depth with explorers
chain.schema.json
Outdated
| }, | ||
| "amount": { | ||
| "type": "string", | ||
| "pattern": "[[:digit:]]+" |
There was a problem hiding this comment.
please use 0-9 for general usage :)
| "type": "string" | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
i think we need to add "additionalProperties": false into $defs/faucet unless you are intended to allow additional properties.
There was a problem hiding this comment.
also we need to wrap regexes with ^ and $
There was a problem hiding this comment.
fixed. is there any other needed option for faucet? @simcheolhwan
No description provided.