Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

milkyway <> skip integration endpoints #173

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

JSHan94
Copy link
Collaborator

@JSHan94 JSHan94 commented Aug 5, 2024

To automate the password update process in case of a password breach of the authorized endpoint of a node, adding an index field for pwd salt generation.

  • add index field for authorized user
  • milkyway setup for skip-api integration

@JSHan94 JSHan94 marked this pull request as draft August 5, 2024 03:40
@Vritra4
Copy link
Contributor

Vritra4 commented Aug 5, 2024

just index sounds ambiguous

@JSHan94
Copy link
Collaborator Author

JSHan94 commented Aug 6, 2024

@Vritra4 how about saltIndex?

@JSHan94 JSHan94 force-pushed the milkyway/skip-endpoints branch from 2b8504d to 985e8cd Compare August 6, 2024 08:10
Copy link

@dhfang dhfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Vritra4
Copy link
Contributor

Vritra4 commented Aug 8, 2024

left a comment for just logging:
I prefer an object as a value because it's easy to extend. If you think there's no chance to extend or update something between us and skip, make it ready for review

@JSHan94 JSHan94 marked this pull request as ready for review August 19, 2024 14:03
@ALPAC-4 ALPAC-4 merged commit 5c0ca96 into initia-labs:main Aug 19, 2024
5 checks passed
@JSHan94 JSHan94 deleted the milkyway/skip-endpoints branch October 21, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants