Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/gen withdrawal hash #65

Merged
merged 3 commits into from
May 28, 2024
Merged

Bug/gen withdrawal hash #65

merged 3 commits into from
May 28, 2024

Conversation

sh-cha
Copy link
Contributor

@sh-cha sh-cha commented May 3, 2024

No description provided.

@sh-cha sh-cha requested a review from beer-1 May 3, 2024 05:19
@sh-cha sh-cha self-assigned this May 3, 2024
@sh-cha sh-cha requested a review from a team as a code owner May 3, 2024 05:19
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.78%. Comparing base (0e5d5a1) to head (c95f456).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   50.71%   50.78%   +0.07%     
==========================================
  Files          57       57              
  Lines        4174     4180       +6     
==========================================
+ Hits         2117     2123       +6     
  Misses       1609     1609              
  Partials      448      448              
Files Coverage Δ
x/ophost/keeper/msg_server.go 58.70% <100.00%> (+0.58%) ⬆️

@beer-1
Copy link
Member

beer-1 commented May 3, 2024

let's merge this after public testnet

Copy link
Member

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - need to update opinit-bots too

@sh-cha
Copy link
Contributor Author

sh-cha commented May 23, 2024

@beer-1 beer-1 merged commit 89f0784 into main May 28, 2024
5 checks passed
@beer-1 beer-1 deleted the bug/gen-withdrawal-hash branch May 28, 2024 03:41
beer-1 pushed a commit that referenced this pull request Jul 9, 2024
* add splitter between variables

* splitter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants