only update price when currenct timestamp is newer than existing one (#…

…59)
initia-labs · Apr 23, 2024 · d02cd19 · d02cd19
1 parent 8d958e7
commit d02cd19
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/x/opchild/l2slinky/aggregator.go b/x/opchild/l2slinky/aggregator.go
@@ -1,6 +1,7 @@
 package l2slinky
 
 import (
+	"errors"
 	"fmt"
 	"math/big"
 	"time"
@@ -48,6 +49,11 @@ func WritePrices(ctx sdk.Context, ok types.OracleKeeper, updatedTime time.Time,
 			continue
 		}
 
+		qp, err := ok.GetPriceForCurrencyPair(ctx, cp)
+		if err == nil && !qp.BlockTimestamp.After(updatedTime) {
+			return errors.New("try to update the past price")
+		}
+
 		// Convert the price to a quote price and write it to state.
 		quotePrice := oracletypes.QuotePrice{
 			Price:          math.NewIntFromBigInt(price),

diff --git a/x/opchild/types/expected_keepers.go b/x/opchild/types/expected_keepers.go
@@ -52,6 +52,7 @@ type BankKeeper interface {
 
 type OracleKeeper interface {
 	GetAllCurrencyPairs(ctx sdk.Context) []slinkytypes.CurrencyPair
+	GetPriceForCurrencyPair(ctx sdk.Context, cp slinkytypes.CurrencyPair) (oracletypes.QuotePrice, error)
 	SetPriceForCurrencyPair(ctx sdk.Context, cp slinkytypes.CurrencyPair, qp oracletypes.QuotePrice) error
 }