Hadar/base math #734
Merged
Hadar/base math #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonHibnik
reviewed
Jan 14, 2025
| @@ -37,6 +39,12 @@ | |||
|
|
|||
| using namespace icicle; | |||
|
|
|||
| #ifdef __CUDA_ARCH__ | |||
| namespace base_math = device_math; | |||
| #else | |||
There was a problem hiding this comment.
We should be able to extend this to Metal and Vulkan as well
There was a problem hiding this comment.
yes, probably
There was a problem hiding this comment.
but metal and vulkan are separate shaders, not sharing this code
There was a problem hiding this comment.
@yshekel I meant the namespace
yshekel
approved these changes
Jan 15, 2025
LeonHibnik
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates cpu (host) math and gpu (device) math from the field class itself. Now the field calls the relevant base math according to the context.
CUDA backend branch
cuda-backend-branch: hadar/base-math