recreated images for poseidon.md #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed image quality
jeremyfelder
approved these changes
Jun 16, 2024
jeremyfelder
requested changes
Jun 16, 2024
| @@ -16,7 +16,9 @@ Poseidon starts with the initialization of its internal state, which is composed | |||
|
|
|||
| This is done to prevent collisions and to prevent certain cryptographic attacks by ensuring that the internal state is sufficiently mixed and unpredictable. | |||
|
|
|||
|  | |||
|  | |||
There was a problem hiding this comment.
The "Alt text" portion should be a description of what the image conveys.
There was a problem hiding this comment.
That info is missing in the original as far as i can see
| @@ -26,7 +28,8 @@ To generate a secure hash output, the algorithm goes through a series of "full r | |||
|
|
|||
| ### Full rounds | |||
|
|
|||
|  | |||
|  | |||
There was a problem hiding this comment.
Is there an image that includes the arrows from each previous stage to the next one?
fixed - added arrows
jeremyfelder
approved these changes
Jun 16, 2024
LeonHibnik
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed 3 images shown in low quality - i have recreated the 3 images - please check me to see that i have not made a mistake