Feat/vlad/signed msm #537
Closed
Feat/vlad/signed msm #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyfelder
reviewed
Jun 9, 2024
| @@ -103,6 +106,7 @@ namespace msm { | |||
| false, // are_results_on_device | |||
| false, // is_big_triangle | |||
| false, // is_async | |||
| false, // is_signed | |||
There was a problem hiding this comment.
If this allows for using less memory AND is faster, why don't we enable is as a default?
There was a problem hiding this comment.
he mentioned that it only works for with the big-triangle accumulation that is slower compared to the other accumulation algorithm.
@vladfdp can you say how does big-triangle + signed compared to the other accumulation without signed optimization?
yshekel
reviewed
Jun 9, 2024
| @@ -73,6 +77,7 @@ func GetDefaultMSMConfig() MSMConfig { | |||
| false, // areResultsOnDevice | |||
| false, // IsBigTriangle | |||
| false, // IsAsync | |||
| false, //IsSigned | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
This PR adds an option to run msm using signed digits.
Currently only works with big triangle
I set the default is_signed to false because big triangle is false by default.
I made the split scalars kernel into two different ones for readibility but I can make it a single one if necessary
Linked Issues
Resolves #