pr comments

ingonyama-zk · Jul 25, 2024 · 0fcbb58 · 0fcbb58
1 parent 15d9cd1
commit 0fcbb58
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/icicle/src/ntt/kernel_ntt.cu b/icicle/src/ntt/kernel_ntt.cu
@@ -703,11 +703,8 @@ namespace mxntt {
     CHK_INIT_IF_RETURN();
 
     if (log_size < 4) {
-      // TODO: should throw exception
       // TODO: fast twiddles should be used only with mixed radix ntt
-      // THROW_ICICLE_ERR(IcicleError_t::InvalidArgument, "log_size must be >= 4");
-      printf("warning: when using fast twiddles, log_size must be at least 4, got %d\n", log_size); // TODO: logging
-      return cudaSuccess;
+      THROW_ICICLE_ERR(IcicleError_t::InvalidArgument, "when using fast twiddles, log_size must be at least 4");
     }
 
     S* w6_table;

diff --git a/icicle/src/ntt/ntt.cu b/icicle/src/ntt/ntt.cu
@@ -469,6 +469,8 @@ namespace ntt {
       CHK_IF_RETURN(mxntt::generate_external_twiddles_generic(
         primitive_root, domain.twiddles, domain.internal_twiddles, domain.basic_twiddles, domain.max_log_size,
         ctx.stream));
+
+      fast_twiddles_mode &= domain.max_log_size >= 4; // fast twiddles cannot be built for smaller domain
 
       if (fast_twiddles_mode) {
         // generating fast-twiddles (note that this cost 4N additional memory)