[IMP] l10n_ar_withholding_ux: apply ratio on base amount #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablohmontenegro
force-pushed
the
17.0-t-42355-pam
branch
3 times, most recently
from
528164c to
5640dfa
Compare
pablohmontenegro
force-pushed
the
17.0-t-42355-pam
branch
3 times, most recently
from
1aa8549 to
e592f01
Compare
pablohmontenegro
force-pushed
the
17.0-t-42355-pam
branch
2 times, most recently
from
b6b2013 to
bf57e37
Compare
pablohmontenegro
force-pushed
the
17.0-t-42355-pam
branch
from
bf57e37 to
3e11b2c
Compare
| @@ -80,6 +80,7 @@ class AccountTax(models.Model): | |||
| 'tax_withholding_id', | |||
| 'Rules', | |||
| ) | |||
| ratio = fields.Float(required=True, default=100, help="Ratio to apply to tax base amount") | |||
There was a problem hiding this comment.
Para quien haga review técnico me queda dudas si debe ser requerido, o si debemos hacer que siempre sea 100 y hacemos que sea solo visible para argentina
zaoral
suggested changes
Nov 8, 2024
| @@ -66,7 +66,7 @@ def get_withholding_vals(self, payment): | |||
| base_amount = vals['withholdable_base_amount'] | |||
|
|
|||
| if self.withholding_type == 'partner_tax': | |||
| amount = base_amount * (alicuota) | |||
| amount = base_amount * (alicuota) * self.ratio / 100 | |||
There was a problem hiding this comment.
Suggested change
| amount = base_amount * (alicuota) * self.ratio / 100 | |
| amount = base_amount * (alicuota) * (self.ratio or 100) / 100 |
| @@ -250,7 +250,7 @@ def _compute_amount( | |||
| if self.amount_type == 'partner_tax': | |||
| date = self._context.get('invoice_date', fields.Date.context_today(self)) | |||
| partner = partner and partner.sudo() | |||
| return base_amount * self.sudo().get_partner_alicuota_percepcion(partner, date) | |||
| return base_amount * self.sudo().get_partner_alicuota_percepcion(partner, date) * self.ratio / 100 | |||
| @@ -80,6 +80,7 @@ class AccountTax(models.Model): | |||
| 'tax_withholding_id', | |||
| 'Rules', | |||
| ) | |||
| ratio = fields.Float(required=True, default=100, help="Ratio to apply to tax base amount") | |||
There was a problem hiding this comment.
remove default and required, extend help
Suggested change
| ratio = fields.Float(required=True, default=100, help="Ratio to apply to tax base amount") | |
| ratio = fields.Float(help="Ratio to apply to tax base amount. If left empty will be 100 % ratio") |
| """ Check that the total percent is not bigger than 100.0 """ | ||
| for tax in self: | ||
| if not (0 < tax.ratio <= 100.0): | ||
| raise ValidationError(_('The total percentage (%s) should be less or equal to 100!', tax.ratio)) |
| @@ -47,6 +47,7 @@ | |||
| </div> | |||
| <field name="withholding_non_taxable_minimum"/> | |||
| <field name="withholding_non_taxable_amount"/> | |||
| <field name="ratio" invisible="country_code != 'AR'"/> | |||
There was a problem hiding this comment.
<label for="ratio" invisible="country_code != 'AR'/>
<div invisible="country_code != 'AR'>
<field name="ratio" class="oe_inline"/>
%
</div>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tarea: 42355