Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document RuntimeEvent access removal in v3 #288

Merged
merged 5 commits into from
Nov 28, 2019
Merged

docs: document RuntimeEvent access removal in v3 #288

merged 5 commits into from
Nov 28, 2019

Conversation

sander
Copy link
Contributor

@sander sander commented Oct 15, 2019

Based on an explanation by @Tim-Linschoten:
#287 (comment)

@codecov-io
Copy link

codecov-io commented Oct 15, 2019

Codecov Report

Merging #288 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #288   +/-   ##
=======================================
  Coverage   80.86%   80.86%           
=======================================
  Files         128      128           
  Lines        3340     3340           
  Branches       91       91           
=======================================
  Hits         2701     2701           
  Misses        639      639

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 095d8ac...1e2c536. Read the comment docs.

@sander
Copy link
Contributor Author

sander commented Oct 21, 2019

@FrancoAra thank you for the approval. Note I cannot merge to master myself. Is this typically done in batches and/or by a second pair of eyes?

@sander
Copy link
Contributor Author

sander commented Nov 6, 2019

Thank you for the merge @stasimus. Not sure if it was in response to my previous comment, but the last required step seems to be merging to master, which should happen by a maintainer:

Screenshot from 2019-11-06 17-54-30

@stasimus stasimus merged commit 4399217 into ing-bank:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants